-
Notifications
You must be signed in to change notification settings - Fork 4
src: generator: hypertable: edition support #20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
src: generator: hypertable: edition support #20
Conversation
606eec7 to
91d6cf0
Compare
|
@sebastian-ederer, can you lend a hand with these last few failing tests? |
|
@anton-schieber Of course, I'll have a look at it tomorrow. |
Add support for the apache and community editions of timescaledb in the hypertable generator.
The checks will now account for editions by checking the current version.
91d6cf0 to
ce02d7d
Compare
…mdscale#12) Use EXECUTE statements inside DO $$ blocks to fix PL/pgSQL limitations where SELECT statements cannot return data without a destination. - Wrap Community-only features in runtime license check - Escape single quotes for EXECUTE string literals - Move chunk_time_interval into create_hypertable() parameters - Update warning message to reference Apache Edition
|
@anton-schieber I fixed all tests and resolved the issues. I had to update the expected SQL for one test, but all other tests failed because of this: In I also changed the P.S. I've abused your branch for a small refactoring to use explicit types instead of |
sebastian-ederer
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
|
Awesome, thanks for that |
|
Yes, I just started the pipeline. Wait for a few minutes then it should've run through. Maybe it takes another couple of minutes until NuGet indexes the new version |
Add support for the apache and community editions of timescaledb in the hypertable generator.
Resolves #12