Community beta #73
Community beta #73
Conversation
Changes to gas cost
🧾 Summary (100% most significant diffs)
Full diff report 👇
|
Vectorized
force-pushed
the
community-beta
branch
from
6b04795 to
02a7066
Compare
There was a problem hiding this comment.
Why the bash script approach instead of standard forge script?
There was a problem hiding this comment.
I usually do the left curved way of manually generating the stuff so that I can deploy and verify in the browser. Cuz it always works with Etherscan and I don’t need to copy private keys. Also for the initcodehash.
Let me know if you have a better way.
| /*-»-»-»-»-»-»-»-»-»-»-»-»-»-»-»-»-»-»-»-»-»-»-»-»-»-»-»-»-»-»*/ | ||
|
|
||
| /// @dev Transient storage slot to denote if the context is in the middle of a `_lzReceive`. | ||
| uint256 internal constant _IN_LZ_RECEIVE_TRANSIENT_SLOT = 0; |
There was a problem hiding this comment.
With solidity 0.8.27 I think we can explicitly declare transient variables now, maybe that turns this cleaner?
There was a problem hiding this comment.
Yes, I have the same thought. Let’s do it.
There was a problem hiding this comment.
Dang, it doesn’t reduce the SLOC in this case, cuz everything that touches the transient stuff are already in the middle of an assembly block.
There was a problem hiding this comment.
Could be good if it reduced SLOC but we're already doing everything in an assembly block so can leave as-is
There was a problem hiding this comment.
I wonder if this file should be a Solady primitive instead of copy-pasted into our project
There was a problem hiding this comment.
Lemme think how to refactor Solady’s tests to allow this.
There was a problem hiding this comment.
solady only copies the relevant parts of forge-std to save on compilation/installation times. sometimes solady mocks don't inherit from test base and so use brutalizer to fuzz in that case
|
|
||
| /// @dev Places multiple bids. | ||
| /// If any token is `address(0)`, it is treated as the native token. | ||
| function placeBids( |
There was a problem hiding this comment.
Convert these to one array of structs instead of four arrays, per convo
No description provided.