Skip to content

[Bugfix #725] Fix CI: move bridge-mode test to integration suite#726

Merged
waleedkadous merged 2 commits intocluesmith:mainfrom
MachineWisdomAI:builder/bugfix-725
May 7, 2026
Merged

[Bugfix #725] Fix CI: move bridge-mode test to integration suite#726
waleedkadous merged 2 commits intocluesmith:mainfrom
MachineWisdomAI:builder/bugfix-725

Conversation

@timeleft--
Copy link
Copy Markdown
Contributor

Summary

Fixes #725

Root Cause

bridge-mode.test.ts spawns Tower via dist/agent-farm/servers/tower-server.js, but the unit-test CI job only builds @cluesmith/codev-core — it does not build packages/codev/dist/. The test was being picked up by the default vitest config and failing with "Cannot find module".

Fix

Renamed bridge-mode.test.tsbridge-mode.e2e.test.ts, which:

  • Excludes it from vitest.config.ts (unit tests) via the existing **/*.e2e.test.ts exclude pattern
  • Includes it in vitest.e2e.config.ts (integration tests) via the existing src/**/*.e2e.test.ts include pattern
  • Follows the established convention — 13 sibling .e2e.test.ts files in the same directory already use this pattern

No config changes needed. Zero-diff rename (file content unchanged).

Test Plan

  • vitest list confirms bridge-mode is NOT in unit test list
  • vitest list --config vitest.e2e.config.ts confirms bridge-mode IS in integration test list
  • vitest run --coverage passes without bridge-mode (exit 0)
  • Existing tests unaffected

timeleft-- and others added 2 commits May 7, 2026 08:02
bridge-mode.test.ts spawns Tower from dist/ which doesn't exist in
the unit-test CI job.  Renaming to .e2e.test.ts excludes it from the
default vitest config (which excludes **/*.e2e.test.ts) and includes
it in vitest.e2e.config.ts (which includes src/**/*.e2e.test.ts),
matching the existing convention for server-spawning integration tests.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
@timeleft--
Copy link
Copy Markdown
Contributor Author

Architect Review

Low-risk CI fix. The root cause was that bridge-mode.test.ts spawned Tower from dist/, but the unit-test workflow does not build packages/codev/dist. Renaming the file to bridge-mode.e2e.test.ts correctly moves the server-spawning coverage into the existing integration-test suite without changing test behavior or CI config.

Validated PR diff and checks: Unit Tests, Tower Integration Tests, CLI Integration Tests, Package Install Verification, and cross-platform CLI checks are all passing.

Approved to merge.


Architect review

Copy link
Copy Markdown
Contributor

@waleedkadous waleedkadous left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you so much for the fix! @otherview just a heads up.

@waleedkadous waleedkadous merged commit bddc98a into cluesmith:main May 7, 2026
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Fix main CI: bridge-mode unit test requires built tower-server dist

2 participants