Skip to content

Conversation

@clue
Copy link
Owner

@clue clue commented Sep 8, 2025

This changeset updates the integration tests to use the more widely supported extended grep instead of PCRE. Among others, this makes it easier to run these tests across different platforms, including macOS and Alpine Linux.

Builds on top of #256, #3 and others
Refs #209 and others

@clue clue added this to the v0.18.0 milestone Sep 8, 2025
@clue clue requested a review from Copilot September 8, 2025 11:59
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR replaces PCRE (Perl-Compatible Regular Expressions) with extended grep to improve cross-platform compatibility for integration tests. The change enables tests to run more reliably across different platforms including macOS and Alpine Linux.

  • Replaces PCRE flag -P with extended grep flag -E across all test assertions
  • Updates regex patterns from [\r\n] to $ for end-of-line matching
  • Adds sed command to strip carriage returns from curl output

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@clue clue merged commit 9d46638 into clue:main Sep 8, 2025
68 checks passed
@clue clue deleted the egrep branch September 8, 2025 12:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant