Skip to content

use socketpair, if possible. #150

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
cloudwu merged 1 commit into from
Apr 9, 2026
Merged

use socketpair, if possible. #150

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 14 additions & 0 deletions src/sockevent.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -95,6 +95,7 @@ sockevent_open(struct sockevent *e) {
#else
if (e->pipe[0] != socket_invalid)
return 0;
#if defined(_WIN32)
socket_t fd = socket(AF_INET6, SOCK_STREAM, 0);
if (fd == socket_invalid)
goto _error;
Expand Down Expand Up @@ -123,6 +124,15 @@ sockevent_open(struct sockevent *e) {
e->pipe[0] = accept(fd, (struct sockaddr *)&loopback, &addrlen);
if (e->pipe[0] == socket_invalid)
goto _error;
#else
int ok = socketpair(PF_UNIX, SOCK_STREAM, 0, e->pipe);
if (ok != 0)
goto _error;
if (none_blocking_(e->pipe[0]) < 0)
goto _error;
if (none_blocking_(e->pipe[1]) < 0)
goto _error;
#endif

#ifdef SO_NOSIGPIPE
const int enable = 1;
Expand All @@ -142,12 +152,16 @@ sockevent_open(struct sockevent *e) {

atomic_int_init(&e->e, 0);

#if defined(_WIN32)
closesocket(fd);
#endif

return 0;
_error:
#if defined(_WIN32)
if (fd == socket_invalid)
closesocket(fd);
#endif
sockevent_close(e);
return -1;
#endif
Expand Down
Loading