fix: correct callback API in ch06 documentation#228
Open
123456wda wants to merge 1 commit into
Open
Conversation
The ch06_callback.md used incorrect API names: - `callbacks.NewHandlerHelper()` → `callbacks.NewHandlerBuilder()` - `.OnStart()` → `.OnStartFn()` - `.OnEnd()` → `.OnEndFn()` - `.OnError()` → `.OnErrorFn()` - `.Handler()` → `.Build()` Also bump eino and eino-ext dependency versions. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ch06_callback.mddocumentationcallbacks.NewHandlerHelper()with.OnStart()/.OnEnd()/.OnError()/.Handler(), which does not match the actual APIcallbacks.NewHandlerBuilder()with.OnStartFn()/.OnEndFn()/.OnErrorFn()/.Build()Background
The quickstart chapter 6 callback example code was inconsistent with the actual
github.com/cloudwego/eino/callbackspackage API. The correct API for building a generic callback handler is:Note:
NewHandlerHelper()lives ingithub.com/cloudwego/eino/utils/callbacksand is for component-specific typed callbacks (e.g.,.ChatModel(),.Tool()), not for generic callbacks.Test plan
ch06_callback.mdgithub.com/cloudwego/eino/callbacksv0.8.13🤖 Generated with Claude Code