fix(adk): resolve path duplication, empty plan.md, and file escape in excel-agent#227
Open
lora-sys wants to merge 1 commit into
Open
fix(adk): resolve path duplication, empty plan.md, and file escape in excel-agent#227lora-sys wants to merge 1 commit into
lora-sys wants to merge 1 commit into
Conversation
|
|
lora-sys
force-pushed
the
fix/excel-agent-paths-planmd-editfile
branch
from
89e5f4b to
fc1f3f2
Compare
… excel-agent - main.go: fix playground path hardcoded to repo root, use relative 'playground/' instead - generic/plan.go: add UnmarshalJSON fallback from 'instruction' to 'desc' - agents/planner/planner.go: fix few-shot example key from 'instruction' to 'desc' - agents/replanner/replanner.go: same prompt fix + guard against empty Steps slice - tools/edit.go: prepend workdir to relative paths to prevent files escaping Fixes cloudwego#226
lora-sys
force-pushed
the
fix/excel-agent-paths-planmd-editfile
branch
from
fc1f3f2 to
c498f88
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
fix
Check the PR title.
(Optional) Translate the PR title into Chinese.
修复 integration-excel-agent 路径重复、plan.md 为空、文件逃逸问题
(Optional) More detailed description for this PR(en: English/zh: Chinese).
en:
Fixes #226
Three bugs in
adk/multiagent/integration-excel-agent/:main.go:79,85 hardcodes
adk/multiagent/integration-excel-agent/playground/..., crashes when runninggo run .from the example dir (path duplication).Planner/replanner prompts use
"instruction"in few-shot examples, but JSON schema expects"desc". LLM follows example → Desc empty → plan.md steps blank. Added UnmarshalJSON fallback for defense in depth.edit_file tool writes to LLM-specified path directly without workdir prefix. python_runner handles this correctly; edit_file now does too.
Also fixes pre-existing gofumpt lint issues in 3 files triggered by the linter config.
zh(optional):
修复三个 bug：路径硬编码导致启动崩溃；prompt 示例字段名与 schema 不一致导致 plan.md 步骤描述为空；edit_file 工具不拼接 workdir 导致文件写到项目根目录。
Which issue(s) this PR fixes:
Fixes #226