refactor(chat): rename llm variable to cm (chatModel) for better naming consistency#121
Closed
MichaelChow wants to merge 1 commit intocloudwego:mainfrom
Closed
refactor(chat): rename llm variable to cm (chatModel) for better naming consistency#121MichaelChow wants to merge 1 commit intocloudwego:mainfrom
MichaelChow wants to merge 1 commit intocloudwego:mainfrom
Conversation
mrh997
reviewed
Sep 30, 2025
|
|
||
| // 创建llm | ||
| log.Printf("===create llm===\n") | ||
| cm := createOpenAIChatModel(ctx) |
Contributor
There was a problem hiding this comment.
More users may use OpenAI. Is it better to use OpenAI by default?
shentongmartin
added
C-maintenance
Contributor
|
Hi @MichaelChow — this PR has been open for over 5 months with no activity. We're going to close it to keep the PR queue tidy. If you're still interested in contributing this change, please feel free to reopen or submit a new PR rebased on the latest |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
rename llm to cm (chatModel) in chat examples for improved readability