Skip to content

fix(deer-go): prevent server initialization panic when APMPLUS_APP_KEY is not set#110

Merged
shentongmartin merged 3 commits intocloudwego:mainfrom
Zerofisher:main
Mar 16, 2026
Merged

fix(deer-go): prevent server initialization panic when APMPLUS_APP_KEY is not set#110
shentongmartin merged 3 commits intocloudwego:mainfrom
Zerofisher:main

Conversation

@Zerofisher
Copy link
Copy Markdown
Contributor

What type of PR is this?

fix: A bug fix

Check the PR title.

  • This PR title match the format: <type>(optional scope): <description>
  • The description of this PR title is user-oriented and clear enough for others to understand.
  • Attach the PR updating the user documentation if the current PR requires user awareness at the usage level. User docs repo

(Optional) Translate the PR title into Chinese.

(Optional) More detailed description for this PR(en: English/zh: Chinese).

en:
zh(optional):

(Optional) Which issue(s) this PR fixes:

Fixes #109

(optional) The PR that updates user documentation:

Copilot AI review requested due to automatic review settings August 30, 2025 10:46
@CLAassistant
Copy link
Copy Markdown

CLAassistant commented Aug 30, 2025

CLA assistant check
All committers have signed the CLA.

Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR fixes a server initialization panic that occurs when the APMPLUS_APP_KEY environment variable is not set. The fix prevents the server from attempting to use tracing middleware when the tracer configuration is incomplete.

  • Modified server initialization logic to conditionally apply tracing middleware only when both tracer and config are available
  • Added fallback server initialization without tracing when configuration is missing

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

Comment thread flow/agent/deer-go/main.go Outdated
Copilot AI review requested due to automatic review settings March 12, 2026 01:42
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review is ineligible. To be eligible to request a review, you need a paid Copilot license, or your organization must enable Copilot code review.

@shentongmartin shentongmartin added C-enhancement This is a PR that adds a new feature or fixes a bug. D-example Domain: this issue relates to an example in the eino-example repository labels Mar 12, 2026
@shentongmartin shentongmartin merged commit 9b0c95d into cloudwego:main Mar 16, 2026
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

C-enhancement This is a PR that adds a new feature or fixes a bug. D-example Domain: this issue relates to an example in the eino-example repository

Development

Successfully merging this pull request may close these issues.

当没有设置 APMPLUS_APP_KEY 时,服务启动 panic

4 participants