Error management for row excel plugin #24
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
psainics
reviewed
Jan 30, 2025
core-plugins/src/main/java/io/cdap/plugin/batch/source/ExcelInputFormat.java
Outdated
Show resolved
Hide resolved
Collaborator
|
Please share the updated error chain |
Collaborator
Author
Updated SS in the description |
psainics
reviewed
Feb 6, 2025
core-plugins/src/main/java/io/cdap/plugin/batch/source/ExcelErrorDetailsProvider.java
Outdated
Show resolved
Hide resolved
Collaborator
|
Upstream PR: cdapio#1935 |
psainics
reviewed
Feb 11, 2025
core-plugins/src/main/java/io/cdap/plugin/batch/source/ExcelErrorDetailsProvider.java
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Error Management for Excel source plugin
Code change
Modified ExcelInputFormat.java
Modified ExcelInputReader.java
Added ExcelErrorDetailsProvider.java
Tests
1. Valid File
2. Invalid file Type
3. Empty Row
4. Invalid Sheet Name
5. Empty File