Initialize attached windows disks in Azure ARM #35
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ivanayov
force-pushed
the
feature/arm-initialize-disk-win
branch
4 times, most recently
from
69d8022 to
adf218b
Compare
ivanayov
changed the title
ivanayov
changed the title
ivanayov
force-pushed
the
feature/arm-initialize-disk-win
branch
from
adf218b to
326f78d
Compare
Contributor
|
Looks good although didn't tested it. |
bostko
reviewed
Jul 25, 2017
| machine, osDeviceName, filesystemType)); | ||
| } | ||
| } else if (machine instanceof WinRmMachineLocation) { | ||
| WinRmToolResponse response = ((WinRmMachineLocation)machine).executePsScript("Get-Disk | Where partitionstyle -eq 'raw' | " + |
Contributor
There was a problem hiding this comment.
You could format a disk which you should not format this way.
I prefer passing explicit disk letter.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.