-
Notifications
You must be signed in to change notification settings - Fork 5
chore: Bump brace-expansion, @typescript-eslint/eslint-plugin, @typescript-eslint/parser, glob, eslint, test-exclude and typescript-eslint #118
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Large diffs are not rendered by default.
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -123,12 +123,11 @@ export function extractTestSelectorsUtil({ srcPath = 'src', libPath = 'lib/compo | |
| } | ||
|
|
||
| function resolveSelectorsPath(importPath: string) { | ||
| let selectorsFile = importPath; | ||
| // Path to selectors file from 'lib folder'. | ||
| selectorsFile = path.resolve(path.relative(libTestUtilsPath, importPath)); | ||
|
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. The new version of eslint did not like this |
||
| const relativeSelectorsFile = path.resolve(path.relative(libTestUtilsPath, importPath)); | ||
| // Absolute path to selectors file. | ||
| selectorsFile = path.resolve(path.join(libPath, selectorsFile)); | ||
| return selectorsFile; | ||
| const absoluteSelectorsFile = path.resolve(path.join(libPath, relativeSelectorsFile)); | ||
| return absoluteSelectorsFile; | ||
| } | ||
|
|
||
| function getComponentNameFromFilePath(filePath: string) { | ||
|
|
||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -32,7 +32,6 @@ export default class DummyWrapper extends ComponentWrapper { | |
| exports[`strip-dom 1`] = ` | ||
| "// Copyright Amazon.com, Inc. or its affiliates. All Rights Reserved. | ||
| // SPDX-License-Identifier: Apache-2.0 | ||
| /* eslint-env browser */ | ||
|
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. These https://eslint.org/docs/latest/use/configure/migration-guide#eslint-env-configuration-comments |
||
|
|
||
| import { ComponentWrapper, ElementWrapper, usesDom } from '../../../../../lib/core/dom'; | ||
| export default class DummyWrapper extends ComponentWrapper { | ||
|
|
@@ -48,7 +47,7 @@ export default class DummyWrapper extends ComponentWrapper { | |
| exports[`strip-external-imports 1`] = ` | ||
| "// Copyright Amazon.com, Inc. or its affiliates. All Rights Reserved. | ||
| // SPDX-License-Identifier: Apache-2.0 | ||
| /* eslint-env browser */ | ||
|
|
||
| import { ComponentWrapper } from "@cloudscape-design/test-utils-core/selectors"; | ||
| import { KeyCode } from "@cloudscape-design/test-utils-core/utils"; | ||
| export default class DummyWrapper extends ComponentWrapper { | ||
|
|
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@eslint/jsis required here but it was not declared as a (dev) dependency:test-utils/eslint.config.js
Line 3 in d5468fc