Skip to content

chore: Add themeable tokens for button #4395

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
at-susie wants to merge 8 commits into
base: main
Choose a base branch
from
Draft

chore: Add themeable tokens for button #4395

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
b060cfc
chore: Add themeable color tokens for link button
at-susie Mar 30, 2026
bb65d8b
chore: Add themeable button spacing tokens
at-susie Mar 30, 2026
76f7637
chore: Update snapshot
at-susie Mar 30, 2026
adcbd4c
chore: Update snapshot
at-susie Mar 30, 2026
941ae0b
chore: Add themeable color tokens for inline button icons
at-susie Mar 30, 2026
2d39112
chore: Update snapshot
at-susie Mar 30, 2026
8fb2f91
chore: Update snapshot
at-susie Mar 30, 2026
08b615a
chore: Replace hardcoded border radius with themeable token
at-susie Mar 31, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 14 additions & 0 deletions pages/theming/themed-stroke-width.page.tsx
View file
Open in desktop
Copy link
Copy Markdown
Member

@jkuelz jkuelz Mar 31, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is the stroke width dev page the right place for these examples? Nothing on the page indicates that there will be other tokens other than the icon stroke widths applied. Your change in particular is about button height and colors. Should we create a new page that allows you to toggle on/off the entire core theme?

Copy link
Copy Markdown
Member Author

@at-susie at-susie Mar 31, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good call. I will create another page or repurpose this page to be more generic

Original file line number Diff line number Diff line change
Expand Up @@ -73,7 +73,10 @@ export default function ThemedStrokeWidthPage() {
borderWidthIconMedium: strokeMedium ? `${strokeMedium}px` : '1px',
borderWidthIconBig: strokeBig ? `${strokeBig}px` : '1.5px',
borderWidthIconLarge: strokeLarge ? `${strokeLarge}px` : '2px',
spaceButtonHorizontal: '12px',
spaceButtonVertical: '4px',
borderRadiusButton: '8px',
borderWidthButton: '1px',
},
};

Expand Down Expand Up @@ -222,6 +225,17 @@ export default function ThemedStrokeWidthPage() {
<Button iconName="call" variant="primary">
Button
</Button>
<Button iconName="call" variant="link">
Button
</Button>
<Button iconName="call" variant="normal">
Button
</Button>
</div>
<div>
<Button variant="primary">Button</Button>
<Button variant="link">Button</Button>
<Button variant="normal">Button</Button>
</div>

<SegmentedControl
Expand Down
64 changes: 64 additions & 0 deletions src/__integ__/__snapshots__/themes.test.ts.snap
View file
Open in desktop

Large diffs are not rendered by default.

Loading
Loading