Skip to content

fix: Remove deprecation annotation on side navigation externalIconAriaLabel link property#4392

Open
SpyZzey wants to merge 2 commits intomainfrom
fix/side-navigation-incorrect-deprecation-externalIconAriaLabel
Open

fix: Remove deprecation annotation on side navigation externalIconAriaLabel link property#4392
SpyZzey wants to merge 2 commits intomainfrom
fix/side-navigation-incorrect-deprecation-externalIconAriaLabel

Conversation

@SpyZzey
Copy link
Copy Markdown
Member

@SpyZzey SpyZzey commented Mar 27, 2026

Description

In #3975, externalIconAriaLabel in the side navigations "link" has been annotated with @deprecated. However, we do not support an alternative for it as #3975 only added the i18n support on an application level, not a per-component basis.

Related links, issue #, if available: AWSUI-61823

Review checklist

The following items are to be evaluated by the author(s) and the reviewer(s).

Correctness

  • Changes include appropriate documentation updates.
  • Changes are backward-compatible if not indicated, see CONTRIBUTING.md.
  • Changes do not include unsupported browser features, see CONTRIBUTING.md.
  • Changes were manually tested for accessibility, see accessibility guidelines.

Security

Testing

  • Changes are covered with new/existing unit tests?
  • Changes are covered with new/existing integration tests?

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@SpyZzey SpyZzey force-pushed the fix/side-navigation-incorrect-deprecation-externalIconAriaLabel branch from 3040b7c to 99e11ae Compare March 27, 2026 17:42
@codecov
Copy link
Copy Markdown

codecov bot commented Mar 27, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 97.45%. Comparing base (f7c23e9) to head (89f0361).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #4392   +/-   ##
=======================================
  Coverage   97.45%   97.45%           
=======================================
  Files         909      909           
  Lines       26637    26637           
  Branches     9615     9615           
=======================================
  Hits        25958    25958           
  Misses        636      636           
  Partials       43       43           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants