Open
Conversation
cb759ce to
5e2c3a3
Compare
b3fa438 to
3f4d535
Compare
3f4d535 to
9f0faad
Compare
69b458f to
d2ebfd6
Compare
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #4107 +/- ##
==========================================
- Coverage 97.45% 97.35% -0.10%
==========================================
Files 909 925 +16
Lines 26637 29116 +2479
Branches 9614 10530 +916
==========================================
+ Hits 25958 28346 +2388
- Misses 673 764 +91
Partials 6 6 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
b1c71c6 to
6ec9bce
Compare
pan-kot
reviewed
Mar 12, 2026
pan-kot
reviewed
Mar 12, 2026
mxschll
reviewed
Mar 12, 2026
mxschll
reviewed
Mar 12, 2026
mxschll
reviewed
Mar 12, 2026
pan-kot
reviewed
Mar 12, 2026
pan-kot
reviewed
Mar 12, 2026
pan-kot
reviewed
Mar 12, 2026
mxschll
reviewed
Mar 12, 2026
mxschll
reviewed
Mar 12, 2026
d7e193a to
7c9cae2
Compare
jperals
reviewed
Mar 13, 2026
pan-kot
reviewed
Mar 13, 2026
3d5686c to
992d693
Compare
pan-kot
reviewed
Mar 26, 2026
pan-kot
reviewed
Mar 26, 2026
pan-kot
reviewed
Mar 26, 2026
jperals
reviewed
Mar 26, 2026
jperals
reviewed
Mar 26, 2026
jperals
reviewed
Mar 26, 2026
| "i18nStrings.datePlaceholder": "GG/MM/AAAA", | ||
| "i18nStrings.isoDatePlaceholder": "AAAA-MM-GG", | ||
| "i18nStrings.slashedDatePlaceholder": "AAAA/MM/GG", | ||
| "i18nStrings.isoDatePlaceholder": "GG-MM-AAAA", |
Member
There was a problem hiding this comment.
These two strings should not change. Instead, i18nStrings.datePlaceholder should be changed to AAAA/MM/GG
jperals
reviewed
Mar 26, 2026
| "i18nStrings.datePlaceholder": "JJ/MM/AAAA", | ||
| "i18nStrings.isoDatePlaceholder": "AAAA-MM-JJ", | ||
| "i18nStrings.slashedDatePlaceholder": "AAAA/MM/JJ", | ||
| "i18nStrings.isoDatePlaceholder": "JJ-MM-AAAA", |
Member
There was a problem hiding this comment.
Same as in Italian, these two strings should not have been change, it is the previous one that was wrong.
We can address existing issues separately but let's not introduce regressions.
jperals
reviewed
Mar 26, 2026
| "i18nStrings.datePlaceholder": "DD/MM/YYYY", | ||
| "i18nStrings.isoDatePlaceholder": "YYYY-MM-DD", | ||
| "i18nStrings.slashedDatePlaceholder": "YYYY/MM/DD", | ||
| "i18nStrings.isoDatePlaceholder": "DD-MM-YYYY", |
Member
There was a problem hiding this comment.
Similar feedback here as with French and Italian below
…ng out of use-token-mode, remove ignoreCursorDetection flag
mxschll
reviewed
Mar 27, 2026
…s updated, enhanced trigger state management, improved test coverage
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Adds shortcuts features to PromptInput:
divwith contenteditable enabled to allow rendering custom elements@or/Related links, issue #, if available: n/a
How has this been tested?
Review checklist
The following items are to be evaluated by the author(s) and the reviewer(s).
Correctness
CONTRIBUTING.md.CONTRIBUTING.md.Security
checkSafeUrlfunction.Testing
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.