feat: Dual y-axis support in cartesian charts#198
Closed
Conversation
Allow CartesianChart to render two Y axes by passing a tuple to the yAxis prop. The second axis is automatically set to opposite (right side). Series can reference the secondary axis with yAxis: 1. Changes: - Add yAxis?: number to BaseCartesianSeriesOptions - Accept yAxis as single or [primary, secondary] tuple in CartesianChartProps - Pass yAxis through all series transform functions - Auto-set opposite: true on the secondary axis - Add unit tests and demo page
1d3c530 to
4cb8cbc
Compare
Member
Author
|
Closed in favour of the original PR which now includes all fixes, too: #182 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
A clone of #182, including:
API: EWhLAhOTR7dr
How has this been tested?
Review checklist
The following items are to be evaluated by the author(s) and the reviewer(s).
Correctness
CONTRIBUTING.md.CONTRIBUTING.md.Security
checkSafeUrlfunction.Testing
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.