Skip to content

fix: Take permutations screenshot before restoring window height #214

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
amanabiy merged 1 commit into from
May 19, 2026
Merged

fix: Take permutations screenshot before restoring window height #214

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions src/page-objects/screenshot.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -84,16 +84,16 @@ export default class ScreenshotPageObject extends BasePageObject {

const permutations = await this.browser.execute(getPermutationSizes);

// Restore window size after taking the screenshot
await this.safeSetWindowSize(originalWindowSize.width, originalWindowSize.height);

if (permutations.length === 0) {
throw new Error('No permutations found on current page.');
}

const screenshot = await this.fullPageScreenshot();
const image = await parsePng(screenshot);

// Restore window size after taking the screenshot
await this.safeSetWindowSize(originalWindowSize.width, originalWindowSize.height);

return permutations.map((permutation: PermutationInfo) => ({ ...permutation, image }));
}

Expand Down
Loading