chore: switch to @tony.ganchev/eslint-plugin-header#401
Open
tonyganchev wants to merge 1 commit intocloudscape-design:mainfrom
Open
chore: switch to @tony.ganchev/eslint-plugin-header#401tonyganchev wants to merge 1 commit intocloudscape-design:mainfrom
tonyganchev wants to merge 1 commit intocloudscape-design:mainfrom
Conversation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Hi, team,
I noticed you are using eslint-plugin-header on ESLint 8.
I forked @tony.ganchev/eslint-plugin-header mid-2024 to add support
for ESLint 9 and hoped it would be a temporary measure but since the
original has not been updated for five years I decided to continue
improving the new plugin and have been doing so for the last two years.
Specific improvements include:
@jest-environmentoreslint-env. In the case of the currentreview, this allowed me to remove the
eslint-disabledirective fromone source and reintroduce validation for its header.
I switched the configuration to use the new config format for v3.2.x
as the leading comments feature is not supported by the array-based
format inherited from eslint-plugin-header.
I've sent PR proposals to other projects in the cloudscape-design
space:
Looking forward to your feedback.
How has this been tested?
Review checklist
The following items are to be evaluated by the author(s) and the reviewer(s).
Correctness
CONTRIBUTING.md.CONTRIBUTING.md.Security
checkSafeUrlfunction.Testing
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.