Skip to content

chore: switch to @tony.ganchev/eslint-plugin-header#401

Open
tonyganchev wants to merge 1 commit intocloudscape-design:mainfrom
tonyganchev:main
Open

chore: switch to @tony.ganchev/eslint-plugin-header#401
tonyganchev wants to merge 1 commit intocloudscape-design:mainfrom
tonyganchev:main

Conversation

@tonyganchev
Copy link
Copy Markdown

@tonyganchev tonyganchev commented Mar 15, 2026

Description

Hi, team,

I noticed you are using eslint-plugin-header on ESLint 8.

I forked @tony.ganchev/eslint-plugin-header mid-2024 to add support
for ESLint 9 and hoped it would be a temporary measure but since the
original has not been updated for five years I decided to continue
improving the new plugin and have been doing so for the last two years.

Specific improvements include:

  • full JSON schema for validating the configuration.
  • fixed multiple bugs with the behavior of the plugin on Windows.
  • many other bug-fixes.
  • improved autofixing and error-reporting behavior.
  • added support for leading pragma comments before the header such as
    @jest-environment or eslint-env. In the case of the current
    review, this allowed me to remove the eslint-disable directive from
    one source and reintroduce validation for its header.

I switched the configuration to use the new config format for v3.2.x
as the leading comments feature is not supported by the array-based
format inherited from eslint-plugin-header.

I've sent PR proposals to other projects in the cloudscape-design
space:

Looking forward to your feedback.

How has this been tested?

npm run lint
Review checklist

The following items are to be evaluated by the author(s) and the reviewer(s).

Correctness

  • Changes include appropriate documentation updates.
  • Changes are backward-compatible if not indicated, see CONTRIBUTING.md.
  • Changes do not include unsupported browser features, see CONTRIBUTING.md.
  • Changes were manually tested for accessibility, see accessibility guidelines.

Security

Testing

  • Changes are covered with new/existing unit tests?
  • Changes are covered with new/existing integration tests?

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Loading
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants