Avoid unnecessary password lookups #24
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When a password is defined for a role, the lookup of the password should be completely avoided. The previous default construct was evaluated in a way that would still access the password lookup, and potentially generate the password, even if one was explicitly provided. The result was correct, but since the password lookup can have side effects, even in check-mode (it creates files), it should not be run if it is not needed.
Avoids a password lookup, when it is not necessary: - When an account specifices a password, no lookup should be made. - When an account is to be removed, no lookup should be made. This makes it possible to override the password without accidentally calling the default password lookup.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.