-
Notifications
You must be signed in to change notification settings - Fork 11
update sidecar containers #103
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
update sidecar containers #103
Conversation
Bumps sig-storage/csi-node-driver-registrar from v2.5.1 to v2.15.0. --- updated-dependencies: - dependency-name: sig-storage/csi-node-driver-registrar dependency-version: v2.15.0 dependency-type: direct:production ... Signed-off-by: dependabot[bot] <support@github.com>
Bumps sig-storage/csi-resizer from v1.6.0 to v2.0.0. --- updated-dependencies: - dependency-name: sig-storage/csi-resizer dependency-version: v2.0.0 dependency-type: direct:production ... Signed-off-by: dependabot[bot] <support@github.com>
Bumps sig-storage/csi-attacher from v4.0.0 to v4.10.0. --- updated-dependencies: - dependency-name: sig-storage/csi-attacher dependency-version: v4.10.0 dependency-type: direct:production ... Signed-off-by: dependabot[bot] <support@github.com>
Bumps sig-storage/csi-provisioner from v3.2.1 to v6.1.0. --- updated-dependencies: - dependency-name: sig-storage/csi-provisioner dependency-version: v6.1.0 dependency-type: direct:production ... Signed-off-by: dependabot[bot] <support@github.com>
…-provisioner-v6.1.0' into julian/update-sidecar-containers
…-resizer-v2.0.0' into julian/update-sidecar-containers
…-attacher-v4.10.0' into julian/update-sidecar-containers
…-node-driver-registrar-v2.15.0' into julian/update-sidecar-containers
|
Thanks! From my understanding, the fix you implemented is necessary if
Interestingly, the announced removal of the feature gate in v5.0.0 still has not oc ecurred. My suggestion is: toggle the feature gate to off, which essentially brings back the old behavior and implement popper Topology support in a dedicated issue (side note: we can probably remove this check at that point: csi-cloudscale/driver/controller.go Line 88 in fa03b5c
In conclusion, it is deemed safe for users to apply this upgrade to their clusters, provided they did not change anything related to how Topology is handled in their cluster. Additionally: v6.1.0 of Let's discuss if we want to stick to older versions of these side-cars for now. |
To pass the integration tests I had to align the mismatched topology keys in
NodeGetInfoandCreateVolumeto"csi.cloudscale.ch/zone".