Skip to content

Conversation

@disperate
Copy link
Contributor

To pass the integration tests I had to align the mismatched topology keys in NodeGetInfo and CreateVolume to "csi.cloudscale.ch/zone".

dependabot bot and others added 12 commits December 11, 2025 12:55
Bumps sig-storage/csi-node-driver-registrar from v2.5.1 to v2.15.0.

---
updated-dependencies:
- dependency-name: sig-storage/csi-node-driver-registrar
  dependency-version: v2.15.0
  dependency-type: direct:production
...

Signed-off-by: dependabot[bot] <support@github.com>
Bumps sig-storage/csi-resizer from v1.6.0 to v2.0.0.

---
updated-dependencies:
- dependency-name: sig-storage/csi-resizer
  dependency-version: v2.0.0
  dependency-type: direct:production
...

Signed-off-by: dependabot[bot] <support@github.com>
Bumps sig-storage/csi-attacher from v4.0.0 to v4.10.0.

---
updated-dependencies:
- dependency-name: sig-storage/csi-attacher
  dependency-version: v4.10.0
  dependency-type: direct:production
...

Signed-off-by: dependabot[bot] <support@github.com>
Bumps sig-storage/csi-provisioner from v3.2.1 to v6.1.0.

---
updated-dependencies:
- dependency-name: sig-storage/csi-provisioner
  dependency-version: v6.1.0
  dependency-type: direct:production
...

Signed-off-by: dependabot[bot] <support@github.com>
…-provisioner-v6.1.0' into julian/update-sidecar-containers
…-resizer-v2.0.0' into julian/update-sidecar-containers
…-attacher-v4.10.0' into julian/update-sidecar-containers
…-node-driver-registrar-v2.15.0' into julian/update-sidecar-containers
@alakae
Copy link
Contributor

alakae commented Dec 19, 2025

Thanks!

From my understanding, the fix you implemented is necessary if persistentvolume.spec.nodeAffinity is set. This happens when csi-provisioner topology support is turned on. To clarify why this was not an issue with the earlier versions of sig-storage/csi-provisioner:

Interestingly, the announced removal of the feature gate in v5.0.0 still has not oc ecurred.

My suggestion is: toggle the feature gate to off, which essentially brings back the old behavior and implement popper Topology support in a dedicated issue (side note: we can probably remove this check at that point:

if req.AccessibilityRequirements != nil {
). Technically, it would not even require your fix in this case, but we should keep it anyways.

In conclusion, it is deemed safe for users to apply this upgrade to their clusters, provided they did not change anything related to how Topology is handled in their cluster.

Additionally: v6.1.0 of external-provisioner officially requires Kubernetes 1.34. Although our test suite also passes with 1.33. Similar problem with v2.0.0 of sig-storage/csi-resizer.

Let's discuss if we want to stick to older versions of these side-cars for now.

@disperate disperate merged commit 66e0b86 into cloudscale-ch:master Dec 23, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants