fix(lint): extract repeated strings as constants to satisfy goconst#51
Open
uwe-mayer wants to merge 2 commits into
Open
fix(lint): extract repeated strings as constants to satisfy goconst#51uwe-mayer wants to merge 2 commits into
uwe-mayer wants to merge 2 commits into
Conversation
Signed-off-by: uwe-mayer <uwe.mayer01@sap.com>
There was a problem hiding this comment.
Pull request overview
This PR addresses new golangci-lint goconst findings by replacing repeated string literals with package-level constants, keeping behavior unchanged while reducing lint noise.
Changes:
- Extracted Prometheus metric label keys into constants in the CareInstruction metrics package.
- Extracted the
ConfigMap.Datakey"config.yaml"into a constant in Shoot OIDC/auth configuration code.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| controller/shoot/auth.go | Replaces repeated "config.yaml" ConfigMap data key usages with a single package constant. |
| controller/careinstruction/metrics.go | Replaces repeated metric label key strings with package-level constants for Prometheus label definitions/usage. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Merging this branch will not change overall coverage
Coverage by fileChanged files (no unit tests)
Please note that the "Total", "Covered", and "Missed" counts above refer to code statements instead of lines of code. The value in brackets refers to the test coverage of that file in the old version of the code. |
Signed-off-by: uwe-mayer <uwe.mayer01@sap.com>
11fcf7e to
41e3ffc
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes goconst lint errors by extracting repeated string literals as constants:
controller/careinstruction/metrics.go: Extract metric label keys (care_instruction,namespace,garden_namespace,shoot_name) as package-level constantscontroller/shoot/auth.go: Extract"config.yaml"ConfigMap data key as a constantThese were flagged by the updated golangci-lint goconst rule.