fix(ui): always apply inline-flex by default to Badge component#1466
Merged
fix(ui): always apply inline-flex by default to Badge component#1466
Conversation
🦋 Changeset detectedLatest commit: 7d6c821 The changes in this PR will be included in the next version bump. This PR includes changesets to release 9 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
4 tasks
Contributor
|
add changeset
guoda-puidokaite
approved these changes
Feb 17, 2026
taymoor89
approved these changes
Feb 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Always apply
inline-flexto Badge component to enable flex alignment properties.Problem
The Badge component has
justify-centeranditems-centerin its base styles, but these CSS properties only take effect when the element hasdisplay: flexordisplay: inline-flex. Previously,inline-flexwas only applied conditionally when theiconprop was truthy, meaning badges without icons had ineffective alignment styles.Changes Made
jn:inline-flextobadgeBaseStylesso it's always applied${icon ? "jn:inline-flex" : ""}from the renderWhy This Is Safe
inline-flexstill flows inline with surrounding text (likeinlineorinline-block)<span>, so inline display is expected behaviorRelated Issues
Testing Instructions
pnpm --filter @cloudoperators/juno-ui-components test Badge- 12 tests passingChecklist
PR Manifesto
Review the PR Manifesto for best practises.