feat(greenhouse): add plugin instance detail page#1462
feat(greenhouse): add plugin instance detail page#1462
Conversation
🦋 Changeset detectedLatest commit: c157997 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
taymoor89
added
the
greenhouse-pr-preview
taymoor89
force-pushed
the
1325-plugin-instance-detail
branch
2 times, most recently
from
043fd97 to
6350305
Compare
![github-code-quality[bot]](https://avatars.githubusercontent.com/u/9919?s=60&v=4){kind=small}
apps/greenhouse/src/components/admin/PluginInstanceDetail/Overview/Configuration.tsx
Fixed
Show fixed
Hide fixed
taymoor89
force-pushed
the
1325-plugin-instance-detail
branch
4 times, most recently
from
bb7c1c6 to
4f9eb70
Compare
taymoor89
force-pushed
the
1325-plugin-instance-detail
branch
from
4f9eb70 to
135e286
Compare
|
|
||
| return ( | ||
| <Tooltip triggerEvent="hover"> | ||
| <TooltipTrigger asChild> |
There was a problem hiding this comment.
Tooltip could be improved
There was a problem hiding this comment.
good point, but this is in the /plugin-presets page where the list has this icon which by default shows the name of the icon as title.
| </DataGrid> | ||
| </Stack> | ||
| </Stack> | ||
| ) |
There was a problem hiding this comment.
could either here or at least in detail contain the supportGroup. It filters correctly, but the Zweifel of the user stays
There was a problem hiding this comment.
good point, added support group column to show it.
| return auth?.data?.raw?.groups?.find((g: any) => g.startsWith("organization:"))?.split(":")[1] | ||
| } | ||
| organization: auth?.data?.raw?.groups?.find((g: any) => g.startsWith("organization:"))?.split(":")[1] ?? "", | ||
| // @ts-expect-error - auth?.data type needs to be properly defined |
There was a problem hiding this comment.
why not check with zod
There was a problem hiding this comment.
Auth data is not typed at all atm. We can do it later at some point because it has to be properly typed either manually or using zod but a type that can be created/inferred once and used everywhere.
taymoor89
force-pushed
the
1325-plugin-instance-detail
branch
from
dd841c7 to
c157997
Compare
2 participants
Summary
This PR implements plugin instance detail page that can be accessible at
/admin/plugin-presets/$pluginPresetName/plugin-instances/$pluginInstance.Changes Made
Adminfrom breadcrumb.Readycondition is color coded rest of these show as default.Teamspage entry as we're not gonna need that.Related Issues
Screenshots (if applicable)
Testing Instructions
pnpm ipnpm TASKChecklist
PR Manifesto
Review the PR Manifesto for best practises.