Skip to content

fix(remediation): create remediation#1202

Open
kanstantsinbuklis-sap wants to merge 1 commit into
mainfrom
kanstantsinbuklis-sap/issue-1189/fix-create-remediation
Open

fix(remediation): create remediation#1202
kanstantsinbuklis-sap wants to merge 1 commit into
mainfrom
kanstantsinbuklis-sap/issue-1189/fix-create-remediation

Conversation

@kanstantsinbuklis-sap
Copy link
Copy Markdown
Collaborator

Description

Fix create remediation

What type of PR is this? (check all applicable)

  • 🍕 Feature
  • 🐛 Bug Fix
  • 📝 Documentation Update
  • 🎨 Style
  • 🧑‍💻 Code Refactor
  • 🔥 Performance Improvements
  • ✅ Test
  • 🤖 Build
  • 🔁 CI
  • 📦 Chore (Release)
  • ⏩ Revert

Related Tickets & Documents

Added tests?

  • 👍 yes
  • 🙅 no, because they aren't needed
  • 🙋 no, because I need help
  • Separate ticket for tests # (issue/pr)

Added to documentation?

  • 📜 README.md
  • 🤝 Documentation pages updated
  • 🙅 no documentation needed
  • (if applicable) generated OpenAPI docs for CRD changes

Signed-off-by: Kanstantsin Buklis <kanstantsin.buklis@sap.com>
@kanstantsinbuklis-sap kanstantsinbuklis-sap marked this pull request as ready for review May 22, 2026 08:38
Copilot AI review requested due to automatic review settings May 22, 2026 08:38
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot wasn't able to review any files in this pull request.

Files not reviewed (1)
  • internal/api/graphql/graph/resolver/mutation.go: Language not supported

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

nil,
)
if err != nil || len(componentResult.Elements) != 1 {
if len(componentResult.Elements) != 1 {
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: I am not a big fan of combining two if statements to if...else if (when condition is not related) but generally when you have the same kind of check under if condition it is better to use 'else if' for readability.

@kanstantsinbuklis-sap kanstantsinbuklis-sap linked an issue May 22, 2026 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

fix(remediation): create remediation

3 participants