Closed
Conversation
meiserloh
reviewed
Nov 4, 2025
meiserloh
reviewed
Nov 4, 2025
| }, | ||
| { | ||
| "Name": "container_config/java_soft_max_heap", | ||
| "Description": "Sets the SoftMaxHeapSize for the CAS java process. This value must be a positive integer followed by one of these units [b,k,m,g] (byte, kibibyte, mebibyte, gibibyte). It must equal or less than the absolute value of 'java_max_ram_percentage'.", |
Contributor
There was a problem hiding this comment.
see other comment. Also it should be added, that this will only be set, if a memory_limit is configured
Co-authored-by: meiserloh <132442180+meiserloh@users.noreply.github.com>
meiserloh
reviewed
Nov 4, 2025
| }, | ||
| { | ||
| "Name": "container_config/java_soft_max_heap", | ||
| "Description": "Sets the SoftMaxHeapSize for the CAS java process. This value must be a positive integer followed by one of these units [b,k,m,g] (byte, kibibyte, mebibyte, gibibyte). It must equal or less than the absolute value of 'java_max_ram_percentage'.", |
Contributor
There was a problem hiding this comment.
Also we should add an example on how to set this size. something like "2G"
meiserloh
reviewed
Nov 4, 2025
| JAVA_OPTS="$JAVA_OPTS -XX:MinRAMPercentage=${MEMORY_LIMIT_MIN_PERCENTAGE}" | ||
|
|
||
| if [ "$(doguctl config "container_config/java_soft_max_heap" -d "empty")" != "empty" ]; then | ||
| # → allows G1 to return unused regions to the OS |
Contributor
There was a problem hiding this comment.
wait, what is this? even if this is correct, it is not our intend why we use this (because we don't have a benefit like this on k8s with a hard memory limit). So more like "tells the GC to stay under this limit if possible"?
Contributor
Author
|
no longer needed |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.