Conversation
|
@jsilvela I need you here! |
jsilvela
left a comment
jsilvela
left a comment
There was a problem hiding this comment.
Thanks for keeping rows to a max length. Makes the review much more granular.
A bunch of suggestions. Nothing really major. I think all optional.
Two things to flag:
- the lack of an image
- the article is pretty long and at points loses focus. IMO could be significantly more focused
| image: | ||
| url: | ||
| attribution: |
There was a problem hiding this comment.
no image ... would be a first. Not even a logo?
| performance tuning across diverse infrastructure—from on-prem to managed | ||
| services. Lately, a major part of his work involves working directly with | ||
| DBtune’s PostgreSQL CloudNativePG integration. In fact, leading the PostgreSQL | ||
| CloudNativePG integration was a highlight for Mohsin, he owned the feature |
There was a problem hiding this comment.
I don't think a comma is right in there. Alternative suggestion.
| CloudNativePG integration was a highlight for Mohsin, he owned the feature | |
| CloudNativePG integration was a highlight for Mohsin: he owned the feature |
|
|
||
| ## A bit of background | ||
|
|
||
| When Mohsin graduated back in 2005, he says he was just following the trend: |
There was a problem hiding this comment.
| When Mohsin graduated back in 2005, he says he was just following the trend: | |
| When Mohsin graduated back in 2005, he says, he was just following the trend: |
| The PostgreSQL community is Mohsin's long-term 'home'. "I have been active in | ||
| it for years, and I always make it a point to step up for volunteer or support | ||
| roles at events. It’s important to give back to the ecosystem that built my | ||
| career." You might have seen Mohsin at a PostgreSQL community event before, he |
There was a problem hiding this comment.
Again, a comma is not right here, IMO.
| career." You might have seen Mohsin at a PostgreSQL community event before, he | |
| career." You might have seen Mohsin at a PostgreSQL community event before: he |
| it for years, and I always make it a point to step up for volunteer or support | ||
| roles at events. It’s important to give back to the ecosystem that built my | ||
| career." You might have seen Mohsin at a PostgreSQL community event before, he | ||
| gave several public talks already. |
There was a problem hiding this comment.
| gave several public talks already. | |
| has given several public talks already. |
| changes simply by patching the Kubernetes object—rather than trying to hack | ||
| config files inside a running container—is incredibly elegant. This is crucial | ||
| for building a safe automation tool. | ||
| * Automatic failover: CNPG handles actual failover, promoting replicas and |
There was a problem hiding this comment.
Unnecessary words.
| * Automatic failover: CNPG handles actual failover, promoting replicas and | |
| * Automatic failover: CNPG handles failover, promoting replicas and |
| DBtune is an agentic AI database optimization service that automatically tunes | ||
| PostgreSQL runtime parameters for optimal performance. Their stack is built to | ||
| handle diverse PostgreSQL environments across different infrastructure layers. | ||
| DBTune is hosted on AWS, using RDS for their own internal PostgreSQL database |
There was a problem hiding this comment.
"using RDS for their own internal PostgreSQL database"
ha.
| helping customers configure the agent in their K8s environments. On any given day, | ||
| I might shift from deep technical benchmarking and research to join user calls. |
There was a problem hiding this comment.
This had already been said a few paragraphs above.
|
|
||
| The biggest head-scratcher the team hit was a conflict between what they wanted | ||
| to tune and what CloudNativePG needs to control. The DBtune engine is used to | ||
| having full reign over `postgresql.conf`. "But we quickly learned that |
There was a problem hiding this comment.
pet peeve: the expression is "full rein" like the reins of a horse, rather than "full reign" like a monarch. Anyway, the mistake is pretty common, so, eh
There was a problem hiding this comment.
jsilvela
left a comment
jsilvela
left a comment
There was a problem hiding this comment.
Sorry, I did not mean to 'approve' previously, so requesting changes now.
I had meant to "Comment" originally.
|
@FloorD I hope you have other reviewers for prose, not just me ..? And, in this repo there are several PRs with approvals that are ready to merge and publish. |
2 participants
Getting this in for review (yes, I know I forgot to sign the commit).