fix( cluster): Fix incorrect creds for replica templates#806
Open
philippemnoel wants to merge 3 commits into
Open
fix( cluster): Fix incorrect creds for replica templates#806philippemnoel wants to merge 3 commits into
philippemnoel wants to merge 3 commits into
Conversation
dosubot
Bot
added
size:M
philippemnoel
force-pushed
the
phil/azure-recovery
branch
from
85ef7ea to
45235cd
Compare
Signed-off-by: Philippe Noël <philippemnoel@gmail.com>
Signed-off-by: Philippe Noël <philippemnoel@gmail.com>
Signed-off-by: Philippe Noël <philippemnoel@gmail.com>
philippemnoel
force-pushed
the
phil/azure-recovery
branch
from
771468c to
e623483
Compare
dosubot
Bot
added
size:XS
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
origin-azure-creds.yaml,origin-google-creds.yaml, andorigin-s3-creds.yamltemplates that read from.Values.recovery.*instead of.Values.replica.origin.objectStore.*These templates are gated on
mode == "replica"but were reading credential values and secret names from therecoveryvalues tree. This is a copy-paste bug from therecovery-*-creds.yamltemplates — the conditions were updated but the data fields were not. In replica mode, therecovery.*values are empty, so the generated secrets would contain blank credentials.For reference,
origin-s3-creds.yamlalready had the correct paths for the S3 access/secret key data fields and therequirederror messages, but the secret name was still reading from.Values.recovery.secret.name.