Skip to content

feat(restorer): add sentinel errors for WAL restore failures #253

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
leonardoce wants to merge 1 commit into
base: main
Choose a base branch
from
+23 −7
Open

feat(restorer): add sentinel errors for WAL restore failures #253

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
30 changes: 23 additions & 7 deletions pkg/restorer/restorer.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,6 +42,21 @@ const (
// ErrWALNotFound is returned when the WAL is not found in the cloud archive
var ErrWALNotFound = errors.New("WAL not found")

// ErrConnectivity is returned when barman-cloud-wal-restore fails due to a
// connectivity issue with the object storage
var ErrConnectivity = errors.New("connectivity failure")

// ErrInvalidWalName is returned when the WAL name is not valid
var ErrInvalidWalName = errors.New("invalid WAL name")

// ErrGeneric is returned when barman-cloud-wal-restore fails with a generic
// error
var ErrGeneric = errors.New("generic error")

// ErrUnrecognizedExitCode is returned when barman-cloud-wal-restore exits with
// an unrecognized exit code
var ErrUnrecognizedExitCode = errors.New("unrecognized exit code")

// WALRestorer is a structure containing every info needed to restore
// some WALs from the object storage
type WALRestorer struct {
Expand Down Expand Up @@ -280,16 +295,17 @@ func (restorer *WALRestorer) Restore(
case exitCodeBucketOrWalNotFound:
return fmt.Errorf("object storage or file not found %s: %w", walName, ErrWALNotFound)
case exitCodeConnectivityError:
return fmt.Errorf("connectivity failure while executing %s, retrying",
utils.BarmanCloudWalRestore)
return fmt.Errorf("connectivity failure while executing %s, retrying: %w",
utils.BarmanCloudWalRestore, ErrConnectivity)
case exitCodeInvalidWalName:
return fmt.Errorf("invalid name for a WAL file: %s", walName)
return fmt.Errorf("invalid name for a WAL file %q: %w", walName, ErrInvalidWalName)
case exitCodeGeneric:
return fmt.Errorf("generic error code encountered while executing %s",
utils.BarmanCloudWalRestore)
return fmt.Errorf("generic error code encountered while executing %s: %w",
utils.BarmanCloudWalRestore, ErrGeneric)
default:
return fmt.Errorf("encountered an unrecognized exit code error: '%d' while executing %s",
return fmt.Errorf("encountered an unrecognized exit code error: '%d' while executing %s: %w",
exitCode,
utils.BarmanCloudWalRestore)
utils.BarmanCloudWalRestore,
ErrUnrecognizedExitCode)
}
}
Loading