fix: stabilize _s query params for better browser caching#1024
Open
fix: stabilize _s query params for better browser caching#1024
Conversation
✅ Deploy Preview for cld-video-player ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
✅ Deploy Preview for cld-vp-esm-pages ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
tsi
changed the title
kalifyaniv-cloudinary
approved these changes
Apr 6, 2026
| ); | ||
|
|
||
| options.queryParams = Object.assign(options.queryParams || {}, options.allowUsageReport ? { _s: `vp-${VERSION}` } : {}); | ||
| options.queryParams = Object.assign(options.queryParams || {}, options.allowUsageReport ? { _s: 'vp' } : {}); |
Contributor
There was a problem hiding this comment.
because we report the version in the internal analytics call?
why do we remove the version?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Use a stable
_s=vpmarker for usage-reporting query strings so URLs cache more predictably across player versions, and avoid merging the video source’squeryParamsonto raw absolute poster URLs so external poster hrefs stay exactly as provided.Changes
_stovp(instead ofvp-<package version>) whenallowUsageReportis on in CloudinarybuildSourceand infetch-configapplet requests.VideoSource.poster(), applythis.queryParams()only when the poster target is not a raw URL, preserving untouched raw poster URLs while still appending params for Cloudinary-derived posters.