Open
Conversation
✅ Deploy Preview for cld-vp-esm-pages ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
✅ Deploy Preview for cld-video-player ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
kalifyaniv-cloudinary
approved these changes
Apr 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Video.js only sends credentialed XHR for remote WebVTT when the HTML5 tech’s
crossOriginisuse-credentials. Cloudinary already usedwithCredentialsfor HLS and source objects, but did not setplayer.crossOrigin, so cookies could be missing for.vttloaded via native tracks (and chapters). Fetch-based SRT/transcript loading also omittedcredentials.Changes
refresh(), setplayer.crossOrigintouse-credentialswhen the currentVideoSourcehaswithCredentials, otherwisenull, beforeplayer.src().fetchFileContentwith acredentialsoption (defaultomit) and passinclude/omitfrom the active source’swithCredentialswhen loading SRT/transcript tracks.fetchFileContentcredential behavior.