Skip to content

Add support for Metadata in complementary asset relation APIs #127

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
kjarmicki-cloudinary wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Add support for Metadata in complementary asset relation APIs #127

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 7 additions & 6 deletions api/admin/asset.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -123,12 +123,13 @@ type QualityAnalysisResult struct {

// RelatedComplementaryAssetResult contains the details about a related complementary asset.
type RelatedComplementaryAssetResult struct {
AssetID string `json:"asset_id"`
PublicID string `json:"public_id"`
ResourceType string `json:"resource_type"`
Type string `json:"type"`
Status string `json:"status"`
ComplementaryType string `json:"complementary_type"`
AssetID string `json:"asset_id"`
PublicID string `json:"public_id"`
ResourceType string `json:"resource_type"`
Type string `json:"type"`
Status string `json:"status"`
ComplementaryType string `json:"complementary_type"`
Metadata map[string]interface{} `json:"metadata"`
}

// AccessibilityAnalysisResult contains the details about accessibility analysis.
Expand Down
7 changes: 4 additions & 3 deletions api/admin/assets.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -454,9 +454,10 @@ func (a *API) DeleteRelatedAssetsByAssetIDs(ctx context.Context, params DeleteRe

// RelatedComplementaryAssetsByAssetIDsParams are the parameters for AddRelatedComplementaryAssetsByAssetIDs.
type RelatedComplementaryAssetsByAssetIDsParams struct {
AssetID string `json:"-"`
RelatedAssetIDs []string `json:"related_asset_ids"`
ComplementaryType string `json:"complementary_type"`
AssetID string `json:"-"`
RelatedAssetIDs []string `json:"related_asset_ids"`
ComplementaryType string `json:"complementary_type"`
Metadata map[string]interface{} `json:"metadata,omitempty"`
}

// AddRelatedComplementaryAssetsByAssetIDs relates an asset to other complementary assets by asset IDs.
Expand Down
5 changes: 4 additions & 1 deletion api/admin/assets_acceptance_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1263,13 +1263,16 @@ func getAddRelatedComplementaryAssetsByAssetIDsTestCases() []AdminAPIAcceptanceT

var testCases []AdminAPIAcceptanceTestCase

params := fmt.Sprintf("{\"related_asset_ids\":[\"%s\",\"%s\"],\"complementary_type\":\"complementary_type\"}", cldtest.AssetID2, cldtest.AssetID3)
params := fmt.Sprintf("{\"related_asset_ids\":[\"%s\",\"%s\"],\"complementary_type\":\"complementary_type\",\"metadata\":{\"test_value\":\"a string\"}}", cldtest.AssetID2, cldtest.AssetID3)
addRelatedComplementaryAssetsByAssetIDsTestCases := []addRelatedComplementaryAssetsByAssetIDsTestCase{
{
requestParams: admin.RelatedComplementaryAssetsByAssetIDsParams{
AssetID: cldtest.AssetID,
RelatedAssetIDs: []string{cldtest.AssetID2, cldtest.AssetID3},
ComplementaryType: "complementary_type",
Metadata: map[string]interface{}{
"test_value": "a string",
},
},
uri: "/resources/related_complementary_assets/" + cldtest.AssetID,
expectedParams: &params,
Expand Down
Loading