Prevent test_timeout from failing when a key is pressed#18
Open
danielparks wants to merge 1 commit intocloudhead:masterfrom
Open
Prevent test_timeout from failing when a key is pressed#18danielparks wants to merge 1 commit intocloudhead:masterfrom
danielparks wants to merge 1 commit intocloudhead:masterfrom
Conversation
`test_timeout()` checks that the timeout parameter works by waiting on stdout to be ready for reading with a timeout of 1 ms. One might guess that stdout would never be ready for reading, but it appears that on macOS, at least, pressing enter while running the tests will cause stdout to be ready for reading, which in turn will cause the test to fail. This switches `test_timeout()` to use `UnixStream::pair()` and just never write to the writer. This works even when keys are pressed while the tests are running.
cloudhead
approved these changes
Jul 20, 2023
Owner
cloudhead
left a comment
cloudhead
left a comment
There was a problem hiding this comment.
Uh strange. This looks good though.
Contributor
Author
|
FWIW, I just confirmed the same behavior on Linux. ¯\_(ツ)_/¯ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
test_timeout()checks that the timeout parameter works by waiting on stdout to be ready for reading with a timeout of 1 ms. One might guess that stdout would never be ready for reading, but it appears that on macOS, at least, pressing enter while running the tests will cause stdout to be ready for reading, which in turn will cause the test to fail.This switches
test_timeout()to useUnixStream::pair()and just never write to the writer. This works even when keys are pressed while the tests are running.Just got to say, stdout being ready for reading is super weird.