Skip to content

Use WebDriverWait on some flaky tests#3798

Open
duanemay wants to merge 2 commits intodevelopfrom
add_waits_flaky_test
Open

Use WebDriverWait on some flaky tests#3798
duanemay wants to merge 2 commits intodevelopfrom
add_waits_flaky_test

Conversation

@duanemay
Copy link
Copy Markdown
Member

No description provided.

Copilot AI review requested due to automatic review settings March 19, 2026 22:37
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR aims to reduce flakiness in UAA integration tests by adding explicit waiting logic (Selenium WebDriverWait) and stabilizing rate-limiting assertions/timing.

Changes:

  • Update Selenium-based tests to wait for page state/DOM readiness before asserting or interacting.
  • Refine the /info rate-limiting integration test to reduce interference from prior requests and make assertions more tolerant.
  • Minor restructuring of a JS-based readiness check to wait until a function is actually defined.

Reviewed changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 4 comments.

File Description
uaa/src/test/java/org/cloudfoundry/identity/uaa/integration/SessionControllerIntegrationTests.java Wait until handleMessage is actually a function before asserting.
uaa/src/test/java/org/cloudfoundry/identity/uaa/integration/feature/RateLimitingIT.java Add timing buffers around rate-limit window and simplify assertions.
uaa/src/test/java/org/cloudfoundry/identity/uaa/integration/feature/LoginIT.java Add WebDriverWait/ExpectedConditions around passcode and meta-refresh checks.
uaa/src/test/java/org/cloudfoundry/identity/uaa/integration/feature/HomeIT.java Add a wait before asserting the profile page header.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Development

Successfully merging this pull request may close these issues.

3 participants