Open
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR aims to reduce flakiness in UAA integration tests by adding explicit waiting logic (Selenium WebDriverWait) and stabilizing rate-limiting assertions/timing.
Changes:
- Update Selenium-based tests to wait for page state/DOM readiness before asserting or interacting.
- Refine the
/inforate-limiting integration test to reduce interference from prior requests and make assertions more tolerant. - Minor restructuring of a JS-based readiness check to wait until a function is actually defined.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 4 comments.
| File | Description |
|---|---|
uaa/src/test/java/org/cloudfoundry/identity/uaa/integration/SessionControllerIntegrationTests.java |
Wait until handleMessage is actually a function before asserting. |
uaa/src/test/java/org/cloudfoundry/identity/uaa/integration/feature/RateLimitingIT.java |
Add timing buffers around rate-limit window and simplify assertions. |
uaa/src/test/java/org/cloudfoundry/identity/uaa/integration/feature/LoginIT.java |
Add WebDriverWait/ExpectedConditions around passcode and meta-refresh checks. |
uaa/src/test/java/org/cloudfoundry/identity/uaa/integration/feature/HomeIT.java |
Add a wait before asserting the profile page header. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
uaa/src/test/java/org/cloudfoundry/identity/uaa/integration/feature/LoginIT.java
Show resolved
Hide resolved
uaa/src/test/java/org/cloudfoundry/identity/uaa/integration/feature/HomeIT.java
Outdated
Show resolved
Hide resolved
uaa/src/test/java/org/cloudfoundry/identity/uaa/integration/feature/RateLimitingIT.java
Show resolved
Hide resolved
uaa/src/test/java/org/cloudfoundry/identity/uaa/integration/feature/RateLimitingIT.java
Show resolved
Hide resolved
Contributor
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
uaa/src/test/java/org/cloudfoundry/identity/uaa/integration/feature/RateLimitingIT.java
Show resolved
Hide resolved
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.