Stratos improvements for Angular 20#5275
Merged
norman-abramovitz merged 99 commits intodevelopfrom Apr 1, 2026
Merged
Conversation
Use Intl.Collator with numeric: true so lists sort app-1, app-2, app-10 instead of app-1, app-10, app-2. Opt-in via type: 'natural-sort' on column configs; GUIDs, dates, and numeric fields keep lexicographic. Filter dropdowns also use natural compare.
make test e2e runs Playwright, cf modifier forces linux/amd64 for build targets, site.mk pattern for site-specific overrides with help integration.
Go 1.25, Node 24, Bun in all workflows. Remove extension from test matrix, suppress EmptyError in kubernetes and cloud-foundry specs, fix TestVerifySession expected body, remove legacy PR triggers.
Follow verb+modifier pattern. Add gitProject field to BUILD_INFO for diagnostics page. Deprecation shim for old fe-version target.
Prefer build-time stamped values over index.html meta tags for git project, branch, commit, and build date. Falls back to meta tags if BUILD_INFO fields are empty.
Add make build cf, make stamp frontend, VERSION override docs. Update Go version to 1.25+. Document one-command CF deployment workflow.
Flat config for Angular 20 with @angular-eslint. Relaxed rules for migration period. Replace TSLint builder with @angular-eslint/builder in angular.json. ESLint packages not yet in package.json — blocked by ajv@8 override conflict.
Remove TSLint configs and legacy .eslintrc. Add eslint.config.mjs with warn-level rules for migration period. Remove ajv@8 override that blocked ESLint. Use bun workspaces for @stratos/builders. Fix empty type parameter in entity-request-pipeline.types.ts. Remove obsolete eslint-disable comments.
Clear user and app preferences on version change to prevent stale data. Add Reset Theme, Reset Lists, Reset Dashboard buttons to Profile Settings alongside existing Reset All.
Test version mismatch clears preferences, version match hydrates normally, first login writes version, clearLocalStorage removes version key, clearSections targets specific sections, clearThemePreferences targets non-user-scoped keys only.
Fix 4 critical Dependabot alerts: gRPC authorization bypass (3 go.mod files) and Docker authz regression.
Electron wrapper and desktop-extensions package are not referenced in the build system, angular.json, or any active code. Removes 5 critical npm vulnerabilities from Dependabot alerts.
Align @Angular-devkit packages with Angular CLI 20.3.18. Remove nested lockfiles from builders package to let bun workspace resolve dependencies from root. Gitignore builders dist/ and node_modules/ — prepare script rebuilds on every install. Existing checkouts may need to delete tools/builders/prebuild-application/node_modules/ manually.
Cloud-foundry and kubernetes test projects fail on EmptyError from unmocked observables. Flag suppresses these until test mocks are fixed (FWT-872).
Extension package has no tests but passWithNoTests flag handles it. All 7 packages now in the matrix.
Update @Angular-devkit packages to latest 20.3.x. Builders package uses caret ranges to resolve from root without manual version sync.
Playwright test captures screenshots from any Stratos deployment. Comparison script generates HTML report with side-by-side images and pixel diffs. CF page discovery needs iteration — currently captures login, home, endpoints, about, and user profile.
Add diagnostics page, endpoints page. Switch to domcontentloaded wait to avoid networkidle timeouts. Use URL-based GUID discovery for CF endpoint. Card click navigation for org/space drill-down (needs further selector tuning for list item cards).
Use /marketplace instead of /marketplace/{cfGuid}.
Switch to domcontentloaded wait with 2s settle delay.
Add card click navigation for org/space discovery.
Data loading timing still needs work for org pages.
Bypass slow card rendering by fetching org/space GUIDs directly from CF API via Stratos proxy. Now captures 16 pages per mode. Still missing app table view and app summary due to slow application list loading.
Use .app-card and .meta-card selectors matching actual DOM structure. Wait for card visibility with 30s timeout. Now captures 16 pages per mode including org summary, spaces, space apps/routes/services. Performance issue was test infrastructure, not CF API (3s response).
Use /applications instead of /cloud-foundry/{cfGuid}/applications
so screenshots work on both v4 and v5 deployments.
Replace fixed 2s settle delay with wait for Retrieving and loading indicators to disappear (30s timeout). Ensures space sub-pages and summary pages are fully loaded before screenshot capture.
Use bg-success-shade-500 and bg-warning-shade-500 instead of bg-success-500 which doesn't exist in the Tailwind config. Status bars were invisible due to unresolved class names.
Replace static target naming with register/declare_verb macros that use $(eval) to generate hidden targets. Introduce _HIDE prefix pattern for internal variables with debug toggle (make _HIDE=). Reorganize by object instead of by verb. Simplify platform detection to two lines using uname+patsubst. Drop backend-all modifier, make build backend cross-compiles all by default with PLATFORM= to narrow. Clean levels: dist and repo.
The git clean approach is too dangerous — would remove .claude/, secrets, and local config files. Parked for redesign with a safe dry-run mechanism.
Track valid modifiers per verb in VALID_MODS; emit a parse-time warning when an unregistered modifier is combined with a verb (e.g. make test cf). Add REGISTRY accumulator for introspection.
Switch clean.dist to flag-gated register; replace hand-crafted clean rule and HAVE_EXPLICIT_TARGET with declare_verb_default. Scope frontend/backend defaults to build/test/dev/stamp only. Fix declare_verb_default_impl to strip whitespace in DEPS check.
This service was not migrated by the inject() schematic and still uses constructor parameters. Restore the useFactory arguments and deps array in the spec.
Remove unused istanbul coverage packages (obsolete with vitest), eliminating 7 handlebars vulnerability alerts. Update happy-dom and @analogjs/vite-plugin-angular. Downgrade angular-eslint from 21.x to 20.7.0 to match Angular 20 and reduce peer dependency conflicts. Add typescript-eslint as explicit dev dependency. Vulnerabilities: 27 → 19. FWT-878
Resolve CF GUID in beforeAll for correct sub-page URLs. Wait for progress bars and content before screenshots. Use 1440x900 viewport for full desktop rendering. Enable Firefox and WebKit projects in Playwright config.
Use correct theme-toggle-button selector for dark mode toggle. Wait for dark-theme class on body after click. Add extra wait for slow CF pages (orgs, users, routes, events). Increase dark mode test timeout to 180s for 3-page navigation. All 20 screenshots now pass including dark mode.
- Add refresh polling indicator to org/space/CF summary sub-nav bars - Fix tile grid: dynamic column recount via tiles.changes subscription, add 5-column support, auto-fit fallback before specific column rules - Fix card header flex layout for right-aligned refresh icon - Fix metric card value/limit wrapping in narrow cards (flex-wrap) - Fix Go proxy 504s: add channel wait timeout (60s default), increase MaxIdleConnsPerHost from 6 to 20, add sensible default timeouts when HTTP_CLIENT_TIMEOUT env vars are not set - Add org summary page to E2E visual inspection tests - Bump version to v4.9.3-dev.76
Delete legacy ThemeService, StyleService, and theme types from the store package. Wire StratosBrandingService.activateUserPreferences() into auth effects after session verification. Remove ThemeService usage from dashboard effects.
Remove copyright, logoText, appName properties and setAppNameFromTitle() method. Branding is now handled by StratosBrandingService. CustomizationService retains only extension component registration slots.
norman-abramovitz
changed the title
StratosBrandingService injects HttpClient and fires a config request on construction. Provide HttpClientTesting in six spec files and absorb the pending company-config request in afterEach.
krutten
approved these changes
Apr 1, 2026
Contributor
krutten
left a comment
krutten
left a comment
There was a problem hiding this comment.
Pairing with Norm on UI improvements for Angular 20 and prep for Angular 21. Releasing as next DEV build
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Test plan
AI Disclosure
AI tooling (Claude Code) was used for code generation, analysis, and testing per CF RFC-0047.