fix wrong validation message for deep module properties #318
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
stiv03
force-pushed
the
fix-validation-messige
branch
from
f6d8f9c to
d45744c
Compare
Yavor16
requested changes
Aug 5, 2025
multiapps-mta/src/main/java/org/cloudfoundry/multiapps/mta/resolvers/PropertiesResolver.java
Outdated
Show resolved
Hide resolved
multiapps-mta/src/main/java/org/cloudfoundry/multiapps/mta/resolvers/PropertiesResolver.java
Outdated
Show resolved
Hide resolved
multiapps-mta/src/main/java/org/cloudfoundry/multiapps/mta/util/NameUtil.java
Outdated
Show resolved
Hide resolved
Comment on lines
78
to
79
| Arguments.of("mtad-with-placeholders-with-depth.yaml", | ||
| new Expectation(Expectation.Type.EXCEPTION, "Unable to resolve \"web-server#web-server-props#routes/0/route\"")), |
Contributor
There was a problem hiding this comment.
Why do we expect now an exception if have changed only the message?
Yavor16
previously approved these changes
Aug 11, 2025
stiv03
force-pushed
the
fix-validation-messige
branch
3 times, most recently
from
31af6c2 to
3758326
Compare
Contributor
theghost5800
left a comment
theghost5800
left a comment
There was a problem hiding this comment.
Fix commit author to be your github personal account instead internal one
| } | ||
|
|
||
| private String buildFullQualifiedPath(Reference reference) { | ||
| String raw = reference.getDependencyName() != null |
Contributor
There was a problem hiding this comment.
Why raw, can we reuse referenceKey name as before?
| // (1) Resolve references in resources - cyclic dependencies & corner cases: | ||
| Arguments.of("merged-02.yaml", new Expectation(Expectation.Type.JSON, "resolved-02.yaml.json")), | ||
| // (2) Test error reporting on failure to resolve value: | ||
| Arguments.of("merged-03.yaml", |
Contributor
There was a problem hiding this comment.
Can you add more failing test cases? Add tests where reference fails for arrays like described in backlog item.
stiv03
force-pushed
the
fix-validation-messige
branch
3 times, most recently
from
5ce06f0 to
7ab7ca5
Compare
theghost5800
approved these changes
Aug 13, 2025
Contributor
|
Squash commits before merge and after merge prepare a release of the project |
Yavor16
approved these changes
Aug 13, 2025
LMCROSSITXSADEPLOY-268
stiv03
force-pushed
the
fix-validation-messige
branch
from
7ab7ca5 to
8522045
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
LMCROSSITXSADEPLOY-268