Skip to content

Fix unmodifiable collection issue #1752

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ikasarov merged 1 commit into from
Dec 11, 2025
Merged

Fix unmodifiable collection issue #1752

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion ...org/cloudfoundry/multiapps/controller/persistence/services/GcpObjectStoreFileStorage.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -205,7 +205,7 @@ private int removeBlobsByFilter(Predicate<? super Blob> filter) {
.toList();
List<Boolean> deletedBlobsResults = new ArrayList<>();
if (!blobIds.isEmpty()) {
deletedBlobsResults = deleteBlobs(blobIds);
deletedBlobsResults.addAll(deleteBlobs(blobIds));
}

deletedBlobsResults.removeIf(Boolean.FALSE::equals);
Expand Down
4 changes: 1 addition & 3 deletions ...cloudfoundry/multiapps/controller/persistence/services/GcpObjectStoreFileStorageTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,6 @@
import java.util.List;
import java.util.Map;
import java.util.UUID;

import com.google.cloud.storage.Blob;
import com.google.cloud.storage.BlobId;
import com.google.cloud.storage.BlobInfo;
Expand All @@ -17,7 +16,6 @@
import org.junit.jupiter.api.AfterEach;
import org.junit.jupiter.api.BeforeEach;
import org.springframework.http.MediaType;

import static org.junit.jupiter.api.Assertions.assertEquals;
import static org.junit.jupiter.api.Assertions.assertNull;

Expand All @@ -43,7 +41,7 @@ protected List<Boolean> deleteBlobs(List<BlobId> blobIds) {
for (BlobId blobId : blobIds) {
deletedBlobsResults.add(storage.delete(blobId));
}
return deletedBlobsResults;
return List.copyOf(deletedBlobsResults);
}
};
spaceId = UUID.randomUUID()
Expand Down
Loading