Revert existing services service key changes #1744

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

IvanBorislavovDimitrov merged 2 commits into master from revert-ext-services

Dec 3, 2025

Merged

Revert existing services service key changes #1744

Revert "Fix service keys not renewed when existing service is used (#…

SonarQubeCloud / SonarCloud Code Analysis failed Dec 3, 2025 in 1m 23s

Quality Gate failed

Failed conditions
19.4% Coverage on New Code (required ≥ 80%)

See analysis details on SonarQube Cloud

Annotations

Check warning on line 69 in multiapps-controller-core/src/main/java/org/cloudfoundry/multiapps/controller/core/cf/clients/CustomServiceKeysClient.java

sonarqubecloud / SonarCloud Code Analysis

Replace this usage of 'Stream.collect(Collectors.toList())' with 'Stream.toList()' and ensure that the list is unmodified.

See more on https://sonarcloud.io/project/issues?id=cloudfoundry_multiapps-controller&issues=AZrkA6NcUiGN7GpYssfR&open=AZrkA6NcUiGN7GpYssfR&pullRequest=1744

Check warning on line 65 in multiapps-controller-core/src/main/java/org/cloudfoundry/multiapps/controller/core/cf/clients/CustomServiceKeysClient.java

sonarqubecloud / SonarCloud Code Analysis

Return an empty collection instead of null.

See more on https://sonarcloud.io/project/issues?id=cloudfoundry_multiapps-controller&issues=AZrkA6NcUiGN7GpYssfQ&open=AZrkA6NcUiGN7GpYssfQ&pullRequest=1744

View more details on SonarQubeCloud