Do not apply MTA archive size limit for transports with multiple MTAs #1551
+79
−33
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
IvanBorislavovDimitrov
left a comment
IvanBorislavovDimitrov
left a comment
There was a problem hiding this comment.
In my opinion instead of this checks
-> Always split the appArchiveId (even in CTS processes it is set -> it might be also comma separated)
-> Just calculate all extensionDescriptors + appArchiveId (all ext descriptors size is not likely to be large)
...n/java/org/cloudfoundry/multiapps/controller/process/steps/ValidateDeployParametersStep.java
Outdated
Show resolved
Hide resolved
Comment on lines
139
to
141
| if (sizeOfAFile >= maxFileSizeLimit) { | ||
| deleteFile(context, fileEntry); | ||
| throw new ContentException(Messages.SIZE_OF_ALL_OPERATIONS_FILES_0_EXCEEDS_MAX_UPLOAD_SIZE_1, sizeOfAFile, maxFileSizeLimit); |
Contributor
There was a problem hiding this comment.
This will throw the exception and not check for the other files
...n/java/org/cloudfoundry/multiapps/controller/process/steps/ValidateDeployParametersStep.java
Outdated
Show resolved
Hide resolved
Contributor
theghost5800
left a comment
theghost5800
left a comment
There was a problem hiding this comment.
My idea for validation improvement was to get somehow file entries/ids which will be currently used for this operation and check them in the same way as it is now. Take a look StartMtaDeploySubProcessStep class how file entries are set before to start xs2-deploy or xs2-bg-deploy process diagrams.
...n/java/org/cloudfoundry/multiapps/controller/process/steps/ValidateDeployParametersStep.java
Outdated
Show resolved
Hide resolved
...n/java/org/cloudfoundry/multiapps/controller/process/steps/ValidateDeployParametersStep.java
Outdated
Show resolved
Hide resolved
Yavor16
force-pushed
the
fix-file-calculation
branch
3 times, most recently
from
b69c748 to
3c3fc92
Compare
...n/java/org/cloudfoundry/multiapps/controller/process/steps/ValidateDeployParametersStep.java
Outdated
Show resolved
Hide resolved
...n/java/org/cloudfoundry/multiapps/controller/process/steps/ValidateDeployParametersStep.java
Outdated
Show resolved
Hide resolved
...n/java/org/cloudfoundry/multiapps/controller/process/steps/ValidateDeployParametersStep.java
Show resolved
Hide resolved
Yavor16
force-pushed
the
fix-file-calculation
branch
from
3c3fc92 to
2c01eee
Compare
...n/java/org/cloudfoundry/multiapps/controller/process/steps/ValidateDeployParametersStep.java
Outdated
Show resolved
Hide resolved
...n/java/org/cloudfoundry/multiapps/controller/process/steps/ValidateDeployParametersStep.java
Outdated
Show resolved
Hide resolved
...n/java/org/cloudfoundry/multiapps/controller/process/steps/ValidateDeployParametersStep.java
Show resolved
Hide resolved
...n/java/org/cloudfoundry/multiapps/controller/process/steps/ValidateDeployParametersStep.java
Show resolved
Hide resolved
...n/java/org/cloudfoundry/multiapps/controller/process/steps/ValidateDeployParametersStep.java
Show resolved
Hide resolved
...n/java/org/cloudfoundry/multiapps/controller/process/steps/ValidateDeployParametersStep.java
Show resolved
Hide resolved
...n/java/org/cloudfoundry/multiapps/controller/process/steps/ValidateDeployParametersStep.java
Outdated
Show resolved
Hide resolved
theghost5800
approved these changes
Oct 31, 2024
Contributor
theghost5800
left a comment
theghost5800
left a comment
There was a problem hiding this comment.
Do not forget to squash the commits into one
IvanBorislavovDimitrov
approved these changes
Nov 4, 2024
Yavor16
force-pushed
the
fix-file-calculation
branch
from
e9061c1 to
f693ddf
Compare
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.