Issue 1265 fix jma property names#1266
Open
stokpop wants to merge 3 commits intocloudfoundry:mainfrom
Open
Conversation
heap_dump_folder set via JBP_CONFIG_JAVA_MEMORY_ASSISTANT was silently ignored because getHeapDumpFolder() never read the config value. Now it takes priority over the volume-service fallback and $PWD default. Added a test using the exact user config to verify all JVM properties on the final command line.
…g test" This reverts commit 45554ad.
Fixes cloudfoundry#1265 The JMA agent expects underscores, not hyphens: - jma.check_interval (not jma.check-interval) - jma.max_frequency (not jma.max-frequency) - jma.heap_dump_folder (not jma.heap-dump-folder) - jma.log_level (not jma.log-level) - jma.thresholds.* (not jma.threshold.*) Also fixes heap_dump_folder config value being silently ignored: it now takes priority over volume-service fallback and $PWD default. log_level is now only emitted when explicitly set. Added tests using the exact user config to verify all JVM properties appear correctly on the final command line.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix for #1265