Fix race condition in route destination updates#4945
Open
philippthun wants to merge 1 commit intocloudfoundry:mainfrom
Open
Fix race condition in route destination updates#4945philippthun wants to merge 1 commit intocloudfoundry:mainfrom
philippthun wants to merge 1 commit intocloudfoundry:mainfrom
Conversation
Move route.reload inside the transaction block to ensure the returned route reflects a consistent state. Previously, a concurrent request could modify or delete the route between transaction commit and reload.
philippthun
force-pushed
the
fix-route-destinations-reload-race-condition
branch
from
83cc761 to
70d1ce4
Compare
philippthun
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Move
route.reloadinside the transaction block to ensure the returned route reflects a consistent state. Previously, a concurrent request could modify or delete the route between transaction commit and reload.I have reviewed the contributing guide
I have viewed, signed, and submitted the Contributor License Agreement
I have made this pull request to the
mainbranchI have run all the unit tests using
bundle exec rakeI have run CF Acceptance Tests