Skip to content

Deployment Updater: Print error class name in case of unexpected error #4647

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jochenehret merged 1 commit into from
Nov 6, 2025
Merged

Deployment Updater: Print error class name in case of unexpected error #4647

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion lib/cloud_controller/deployment_updater/updater.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59,7 +59,7 @@ def with_error_logging(error_message)
if APPROVED_ERRORS.include?(e.class)
deployment.update(error: e.message)
else
deployment.update(error: 'An unexpected error has occurred.')
deployment.update(error: "An unexpected error has occurred: #{error_name}")
end
rescue StandardError => new_error
logger.error(
Expand Down
8 changes: 4 additions & 4 deletions spec/unit/lib/cloud_controller/deployment_updater/updater_spec.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -184,7 +184,7 @@ module VCAP::CloudController
subject.scale
end.not_to raise_error

expect(deployment.error).to eq 'An unexpected error has occurred.'
expect(deployment.error).to eq 'An unexpected error has occurred: StandardError'
end
end
end
Expand Down Expand Up @@ -396,7 +396,7 @@ module VCAP::CloudController
subject.canary
end.not_to raise_error

expect(deployment.error).to eq 'An unexpected error has occurred.'
expect(deployment.error).to eq 'An unexpected error has occurred: StandardError'
end
end
end
Expand Down Expand Up @@ -429,7 +429,7 @@ module VCAP::CloudController
subject.cancel
end.not_to raise_error

expect(deployment.error).to eq 'An unexpected error has occurred.'
expect(deployment.error).to eq 'An unexpected error has occurred: StandardError'
end
end
end
Expand Down Expand Up @@ -460,7 +460,7 @@ module VCAP::CloudController

it 'provides a helpful error on the deployment model' do
subject.scale
expect(deployment.error).to eq 'An unexpected error has occurred.'
expect(deployment.error).to eq 'An unexpected error has occurred: StandardError'
end
end

Expand Down