Open
Conversation
Configure storage-cli WebDAV endpoints to include resource-specific
directory keys (cc-droplets, cc-packages, cc-buildpacks, cc-resources)
for backward compatibility with fog/webdav client.
When using basic auth, endpoints are: /admin/{directory_key}
When using signed URLs, endpoints are: /{directory_key}
This ensures both storage-cli and fog/webdav store blobs at identical
physical paths, enabling zero-downtime rollback between the two clients.
Updated all job templates and RSpec tests to expect directory keys in
endpoint paths.
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Needs new storage-cli release with cloudfoundry/storage-cli#70 to be in first
A short explanation of the proposed change:
Add support for optional signing_method configuration field in WebDAV/DAV storage-cli config templates across all Cloud Controller jobs. This allows operators to specify which URL
signing method (SHA256 or MD5) the storage-cli should use when generating signed blobstore URLs.
An explanation of the use cases your change solves
nginx blobstore configuration, which only supports MD5 signed URLs.
the deployment manifest.
deployments.
Changes Made:
a. Added signing_method field pass-through (optional)
b. Fixed endpoint to use private_endpoint + "/admin/" (correct authenticated upload path)
c. Fixed TLS cert structure to {"cert":{"ca":ca_cert}} (correct storage-cli format)
Example Manifest Usage:
Links to any other associated PRs
I have viewed signed and have submitted the Contributor License Agreement
I have made this pull request to the
developbranchI have run CF Acceptance Tests on bosh lite