Don't package match when given a tarball #687
Draft
+16
−51
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Package matching is great for itterating on a release, but when a tarball is provided, the changes of amatch are slim to none. Before this change, tarballs would be repackaged even if no matches where found.
rkoster
requested review from
a team,
anshrupani,
jpalermo and
klakin-pivotal
and removed request for
a team
cf-foundation-community-automation
bot
moved this to Inbox
in Foundational Infrastructure Working Group
jpalermo
moved this from Inbox
to Pending Review | Discussion
in Foundational Infrastructure Working Group
|
Concern we found at the FIWG meeting. It seems likely that the current change breaks uploading a release yaml file. |
aramprice
requested review from
a team and
fmoehler
and removed request for
a team and
jpalermo
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Package matching is great for itterating on a release, but when a tarball is provided, the changes of amatch are slim to none. Before this change, tarballs would be repackaged even if no matches where found.