As a Diego Client, I can update ImageUsername/ImagePassword #136
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Support updating imageUserName and imagePassword. Update specs.
cf-foundation-community-automation
bot
moved this to Inbox
in Application Runtime Platform Working Group
Fix test issues
Update json marshal and unmarshal
Update spec for marshal/unmarshal json to include image_username and image_password
geofffranks
reviewed
Dec 19, 2025
Update from code review
geofffranks
reviewed
Dec 19, 2025
geofffranks
reviewed
Dec 19, 2025
geofffranks
requested changes
Dec 19, 2025
Contributor
geofffranks
left a comment
geofffranks
left a comment
There was a problem hiding this comment.
Overall looks good, requested a couple small changes
Cleanup and additional tests for code review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Support updating imageUserName and imagePassword. Update specs.
Summary
Backward Compatibility
Breaking Change? No
Ran the tests
/repo/scripts/docker/test.bash bbs
Sourcing: built-binaries/nats-server/run.bash
Sourcing: built-binaries/proxy/run.bash
Setting env: DB_USER
Setting env: DB_PASSWORD
Verifying: verify_go repo/src/code.cloudfoundry.org/bbs
go version go1.25.5 linux/amd64
Verifying: verify_go_version_match_bosh_release repo
Verifying: verify_gofmt repo/src/code.cloudfoundry.org/bbs
Verifying: verify_govet repo/src/code.cloudfoundry.org/bbs
github.com/onsi/gomega/format: /usr/local/go/pkg/tool/linux_amd64/vet: signal: segmentation fault
golang.org/x/text/width: /usr/local/go/pkg/tool/linux_amd64/vet: signal: segmentation fault
code.cloudfoundry.org/bbs/db/sqldb_test: /usr/local/go/pkg/tool/linux_amd64/vet: signal: segmentation fault
---Debug Report Starting--
extract-default-params-for-task with values from /ci/diego-release/default-params/run-bin-test/linux.yml
expand_functions Starting
expand_functions Ending
export NATS_SERVER_BINARY="$PWD/built-binaries/nats-server/run"
export PROXY_BINARY="$PWD/built-binaries/proxy/envoy"
expand_envs Starting
expand_envs Ending
expand_verifications Starting
running get_go_version_for_release with args repo
golang-*linux
Finding the go version for golang-*linux
running get_go_version_for_package with args 1e4dadb8a796a20044e177a108eec65780cd59c308da84f7fdbfdbc758cdf312
golang-1.25-linux
---Debug Report Ending--
Testing in a shepherd environment with the changes
compute/8783da6a-790b-4021-a909-cdbb36c1d7ed:
$ cfdot desired-lrp 4f30f720-1e47-4e62-8b0a-47c6e5bb8051-5b3105df-5e94-4181-9f25-100db90dfd11 | jq .image_username$ cfdot update-desired-lrp 4f30f720-1e47-4e62-8b0a-47c6e5bb8051-5b3105df-5e94-4181-9f25-100db90dfd11 @./update_image.json"sn023555"
compute/8783da6a-790b-4021-a909-cdbb36c1d7ed:
compute/8783da6a-790b-4021-a909-cdbb36c1d7ed:~$ cfdot desired-lrp 4f30f720-1e47-4e62-8b0a-47c6e5bb8051-5b3105df-5e94-4181-9f25-100db90dfd11 | jq .image_username
"sn"