Skip to content

Handle index errors when selecting plugin endpoints #42

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ImMin5 merged 1 commit into from
Mar 5, 2025
Merged

Handle index errors when selecting plugin endpoints #42

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
38 changes: 17 additions & 21 deletions src/spaceone/plugin/service/plugin_service.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -264,9 +264,23 @@ def _select_endpoint(self, plugin_ref, updated_version=None):
f"[_select_endpoint] select endpoint. (index = {current_index}, endpoints = {endpoints})"
)

endpoint = self._get_current_index_endpoint(
endpoints, installed_plugin.current_index, installed_plugin.plugin_id
)
try:
endpoint = endpoints[current_index]
except IndexError:
_LOGGER.debug(
f"[_get_current_index_endpoint] Index Error plugin_id: {installed_plugin.plugin_id},"
f" current_index: {current_index}, endpoints: {endpoints}"
)
return endpoints[0]
except Exception as e:
_LOGGER.error(
f"[_get_current_index_endpoint] plugin_id: {installed_plugin.plugin_id}, endpoints: {endpoints}, "
f" installed plugin index {installed_plugin.current_index}, current_index: {current_index},"
f" error: {e}"
)
raise ERROR_PLUGIN_ENDPOINT_NOT_FOUND(
plugin_id=installed_plugin.plugin_id
)

endpoint_info = {"endpoint": endpoint}

Expand Down Expand Up @@ -359,21 +373,3 @@ def verify(self, params: dict):
self.plugin_mgr.verify_plugin(
plugin_endpoint_info.get("endpoint"), api_class, options, secret_data
)

@staticmethod
def _get_current_index_endpoint(
endpoints: list, current_index: int, plugin_id: str
) -> str:
try:
return endpoints[current_index]
except IndexError:
randon_index = secrets.randbelow(len(endpoints))
_LOGGER.debug(
f"[_get_current_index_endpoint] current_index: {current_index}, randon_index: {randon_index}"
)
return endpoints[randon_index]
except Exception as e:
_LOGGER.error(
f"[_get_current_index_endpoint] plugin_id: {plugin_id}, endpoints: {endpoints}, current_index: {current_index}, error: {e}"
)
raise ERROR_PLUGIN_ENDPOINT_NOT_FOUND(plugin_id=plugin_id)
Loading