feat(service-account): add new service account (Azure) management group mapping method by piggggggggy · Pull Request #6023 · cloudforet-io/console

piggggggggy · 2025-07-17T06:37:59Z

Skip Review (optional)

Minor changes that don't affect the functionality (e.g. style, chore, ci, test, docs)
Previously reviewed in feature branch, further review is not mandatory
Self-merge allowed for solo developers or urgent changes

Description (optional)

SSIA

Things to Talk About (optional)

…or azure account (azure management group) feat(trusted-account-auto-sync): apply new auto-sync mapping method for azure account (azure management group)

…thod (#6017) * feat(azure-account): apply changed azure account workspace mapping method Signed-off-by: samuel.park <samuel.park@megazone.com> * chore: apply review Signed-off-by: samuel.park <samuel.park@megazone.com> --------- Signed-off-by: samuel.park <samuel.park@megazone.com>

vercel · 2025-07-17T06:38:04Z

The latest updates on your projects. Learn more about Vercel for Git ↗︎

2 Skipped Deployments

Name	Status	Preview	Comments	Updated (UTC)
console	⬜️ Ignored (Inspect)			Jul 17, 2025 6:38am
web-storybook	⬜️ Ignored (Inspect)			Jul 17, 2025 6:38am

github-actions · 2025-07-17T06:38:09Z

⚠️ @piggggggggy the signed-off-by was not found in the following 1 commits:

f793cf9: feat(trusted-account-auto-sync): apply new auto-sync mapping method for azure account (azure management group)

✅ Why it is required

The Developer Certificate of Origin (DCO) is a lightweight way for contributors to certify that they wrote or otherwise have the right to submit the code they are contributing to the project. Here is the full text of the DCO.

Contributors sign-off that they adhere to these requirements by adding a Signed-off-by line to commit messages.

This is my commit message

Signed-off-by: Random Developer <randomdeveloper@example.com>

Git even has a -s command line option to append this automatically to your commit message:

$ git commit -s -m 'This is my commit message'

Copilot

Pull Request Overview

This PR adds support for Azure Management Group mapping methods to the service account auto-sync functionality. The implementation introduces new mapping options specifically for Azure accounts to handle management groups at both top-level and leaf-level configurations.

Key changes include:

Added new Azure Management Group mapping types and constants
Extended service account form state to include Azure-specific mapping configuration
Updated auto-sync mapping UI to support Azure Management Group options
Enhanced API schema to support the new Azure mapping parameters

Reviewed Changes

Copilot reviewed 11 out of 11 changed files in this pull request and generated 5 comments.

Show a summary per file

File	Description
service-account-page-store.ts	Extended form state interface and added Azure management group mapping type field
ServiceAccountAddPage.vue	Updated account creation to include Azure management group mapping parameter
auto-sync-options-contant.ts	Added comprehensive mapping options configuration for all CSP providers including Azure
ServiceAccountAutoSyncMappingMethod.vue	Major refactor to support Azure management group mapping with new utility functions
ServiceAccountAutoSync.vue	Updated sync options to include Azure management group mapping type
InfoTooltip.vue	New reusable tooltip component for providing additional information
trusted-account schema files	Added Azure management group mapping type definitions and API parameter support

Copilot · 2025-07-17T06:39:17Z

apps/web/src/services/service-account/constants/auto-sync-options-contant.ts

@@ -0,0 +1,83 @@
+import { AZURE_MANAGEMENT_GROUP_MAPPING_TYPE } from '@/api-clients/identity/trusted-account/schema/constant';


The filename contains a typo: 'auto-sync-options-contant.ts' should be 'auto-sync-options-constant.ts'

Copilot · 2025-07-17T06:39:17Z

apps/web/src/services/service-account/components/ServiceAccountAutoSyncMappingMethod.vue

+/* Utils */
+/*
+* This functions are used to convert the mapping method form data to the service account form data.
+* And also, convert the service account form data to the mapping method form data.
+*
+* 1. convertToMappingMethodDTO
+* 2. convertToMappingMethodClientEntity
+*
+* Azure Account has additional mapping method options (Top Node Management Group, Leaf Node Management Group).
+*/


[nitpick] The comment block starting with '/* Utils /' should use proper JSDoc format or be more descriptive. Consider using '/* Utility Functions */' for better documentation standards.

Suggested change

/* Utils */

/*

* This functions are used to convert the mapping method form data to the service account form data.

* And also, convert the service account form data to the mapping method form data.

*

* 1. convertToMappingMethodDTO

* 2. convertToMappingMethodClientEntity

*

* Azure Account has additional mapping method options (Top Node Management Group, Leaf Node Management Group).

*/

/**

* Utility Functions

*

* These functions are used to convert the mapping method form data to the service account form data,

* and vice versa. They handle the transformation of data between the mapping method and the service

* account forms.

*

* Functions included:

* 1. convertToMappingMethodDTO

* 2. convertToMappingMethodClientEntity

*

* Note: Azure Account has additional mapping method options (Top Node Management Group, Leaf Node Management Group).

*/

Copilot · 2025-07-17T06:39:18Z

apps/web/src/services/service-account/components/ServiceAccountAutoSyncMappingMethod.vue

+/*
+* This functions are used to convert the mapping method form data to the service account form data.
+* And also, convert the service account form data to the mapping method form data.
+*
+* 1. convertToMappingMethodDTO
+* 2. convertToMappingMethodClientEntity
+*
+* Azure Account has additional mapping method options (Top Node Management Group, Leaf Node Management Group).
+*/


[nitpick] Multi-line comments should use JSDoc format (/** ... */) for better documentation consistency, especially for function descriptions.

Suggested change

/*

* This functions are used to convert the mapping method form data to the service account form data.

* And also, convert the service account form data to the mapping method form data.

*

* 1. convertToMappingMethodDTO

* 2. convertToMappingMethodClientEntity

*

* Azure Account has additional mapping method options (Top Node Management Group, Leaf Node Management Group).

*/

/**

* Utility functions for converting mapping method form data to service account form data,

* and vice versa. These functions handle specific cases for Azure accounts, which have

* additional mapping method options (e.g., Top Node Management Group, Leaf Node Management Group).

*

* Functions:

* 1. `convertToMappingMethodDTO`: Converts mapping method form data to service account form data.

* 2. `convertToMappingMethodClientEntity`: Converts service account form data to mapping method form data.

*/

Copilot · 2025-07-17T06:39:18Z

apps/web/src/services/service-account/components/ServiceAccountAutoSyncMappingMethod.vue

+
+
+
+/* Event */


[nitpick] The comment '/* Event /' should be more descriptive, such as '/* Event Handlers */' and use JSDoc format.

Suggested change

/* Event */

/**

* Event Handlers

*

* These functions handle user interactions and update the application state accordingly.

*/

Copilot · 2025-07-17T06:39:18Z

apps/web/src/api-clients/identity/trusted-account/schema/constant.ts

+export const AZURE_MANAGEMENT_GROUP_MAPPING_TYPE = {
+    TOP_MANAGEMENT_GROUP: 'Top Management Group',
+    LEAF_MANAGEMENT_GROUP: 'Leaf Management Group',


The constant values 'Top Management Group' and 'Leaf Management Group' are human-readable strings but should ideally be machine-readable constants (e.g., 'TOP_MANAGEMENT_GROUP', 'LEAF_MANAGEMENT_GROUP') to avoid potential issues with string comparisons and internationalization.

Suggested change

export const AZURE_MANAGEMENT_GROUP_MAPPING_TYPE = {

TOP_MANAGEMENT_GROUP: 'Top Management Group',

LEAF_MANAGEMENT_GROUP: 'Leaf Management Group',

export const TOP_MANAGEMENT_GROUP_LABEL = 'Top Management Group';

export const LEAF_MANAGEMENT_GROUP_LABEL = 'Leaf Management Group';

export const AZURE_MANAGEMENT_GROUP_MAPPING_TYPE = {

TOP_MANAGEMENT_GROUP: TOP_MANAGEMENT_GROUP_LABEL,

LEAF_MANAGEMENT_GROUP: LEAF_MANAGEMENT_GROUP_LABEL,

piggggggggy added 2 commits July 7, 2025 14:38

feat(trusted-account-auto-sync): apply new auto-sync mapping method f…

f793cf9

…or azure account (azure management group) feat(trusted-account-auto-sync): apply new auto-sync mapping method for azure account (azure management group)

piggggggggy requested a review from Copilot July 17, 2025 06:37

piggggggggy added the self_approved/review Pull Request has been reviewed and approved by the author without requiring additional reviewers. label Jul 17, 2025

github-actions bot added the fail/signedoff label Jul 17, 2025

Copilot AI reviewed Jul 17, 2025

View reviewed changes

piggggggggy merged commit 0be6afd into develop Jul 17, 2025
10 of 11 checks passed

github-actions bot mentioned this pull request Jul 17, 2025

feat(trusted-account-auto-sync): apply new Azure Account auto-sync mapping method (management group) #6024

Merged

3 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat(service-account): add new service account (Azure) management group mapping method #6023

feat(service-account): add new service account (Azure) management group mapping method #6023
piggggggggy merged 2 commits intodevelopfrom
feature-azure-account-auto-sync-enhancement

piggggggggy commented Jul 17, 2025

Uh oh!

vercel bot commented Jul 17, 2025

Uh oh!

github-actions bot commented Jul 17, 2025

Uh oh!

Copilot AI left a comment

Uh oh!

Copilot AI Jul 17, 2025

Uh oh!

Copilot AI Jul 17, 2025

Uh oh!

Copilot AI Jul 17, 2025

Uh oh!

Copilot AI Jul 17, 2025

Uh oh!

Copilot AI Jul 17, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

		@@ -0,0 +1,83 @@
		import { AZURE_MANAGEMENT_GROUP_MAPPING_TYPE } from '@/api-clients/identity/trusted-account/schema/constant';

-/*
-* This functions are used to convert the mapping method form data to the service account form data.
-* And also, convert the service account form data to the mapping method form data.
-*
-* 1. convertToMappingMethodDTO
-* 2. convertToMappingMethodClientEntity
-*
-* Azure Account has additional mapping method options (Top Node Management Group, Leaf Node Management Group).
-*/
+/**
+ * Utility functions for converting mapping method form data to service account form data,
+ * and vice versa. These functions handle specific cases for Azure accounts, which have
+ * additional mapping method options (e.g., Top Node Management Group, Leaf Node Management Group).
+ *
+ * Functions:
+ * 1. `convertToMappingMethodDTO`: Converts mapping method form data to service account form data.
+ * 2. `convertToMappingMethodClientEntity`: Converts service account form data to mapping method form data.
+ */

-/* Event */
+/**
+ * Event Handlers
+ *
+ * These functions handle user interactions and update the application state accordingly.
+ */

Conversation

piggggggggy commented Jul 17, 2025

Skip Review (optional)

Description (optional)

Things to Talk About (optional)

Uh oh!

vercel bot commented Jul 17, 2025

Uh oh!

github-actions bot commented Jul 17, 2025

✅ Why it is required

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Reviewed Changes

Uh oh!

Copilot AI Jul 17, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Jul 17, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Jul 17, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Jul 17, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Jul 17, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants