feat: modify user group menu condition#5996
Merged
Conversation
Signed-off-by: NaYeong,Kim <nayeongkim@megazone.com>
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ |
Contributor
|
✅ There are no commits in this PR that require review. |
Contributor
|
🎉 @seungyeoneeee has been randomly selected as the reviewer! Please review. 🙏 |
There was a problem hiding this comment.
Pull Request Overview
This PR refines the condition for inserting the USER_GROUP menu by ensuring the Alert Manager feature is explicitly enabled.
- Introduces an
isEnabledAlertManagerflag fromconfig - Updates the
ifcheck to require bothENABLEDandVERSION === 'V2'before addingUSER_GROUP
Comments suppressed due to low confidence (3)
apps/web/src/services/iam/configurator.ts:37
- [nitpick] Consider renaming
isEnabledAlertManagertoalertManagerEnabledfor improved readability and alignment with common boolean naming conventions.
const isEnabledAlertManager = config?.ALERT_MANAGER?.ENABLED;
apps/web/src/services/iam/configurator.ts:57
- Add a unit test for the scenario where
ALERT_MANAGER.ENABLEDisfalsebutVERSIONis'V2'to verify that theUSER_GROUPmenu is not inserted.
if (isEnabledAlertManager && alertManagerVersion === 'V2') {
apps/web/src/services/iam/configurator.ts:37
- [nitpick] For clearer grouping of related properties, consider destructuring
ALERT_MANAGERfromconfig(e.g.,const { ENABLED: alertManagerEnabled, VERSION: alertManagerVersion } = config?.ALERT_MANAGER ?? {};).
const isEnabledAlertManager = config?.ALERT_MANAGER?.ENABLED;
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Skip Review (optional)
style,chore,ci,test,docs)Description (optional)
SSIA
Things to Talk About (optional)