Conversation
Signed-off-by: NaYeong,Kim <nayeongkim@megazone.com>
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ |
Contributor
|
✅ There are no commits in this PR that require review. |
Contributor
|
🎉 @seungyeoneeee has been randomly selected as the reviewer! Please review. 🙏 |
| @@ -61,9 +61,9 @@ const state = reactive<State>({ | |||
| { label: 'Fixed Amount', name: 'FIXED_AMOUNT' }, | |||
| ]), | |||
| variationMenu: computed(() => [ | |||
There was a problem hiding this comment.
Consider removing this commented-out code or adding a TODO comment explaining why 'All' is disabled and when it will be re-enabled to improve code clarity.
Suggested change
| variationMenu: computed(() => [ | |
| variationMenu: computed(() => [ | |
| // TODO: 'All' option is currently disabled due to incomplete implementation. Re-enable when the functionality for handling 'all' variations is added. |
| variationMenu: computed(() => [ | ||
| { label: 'All', name: 'all' }, | ||
| // { label: 'All', name: 'all' }, | ||
| { label: 'Increase (>=)', name: JSON.stringify(['gte']) }, |
There was a problem hiding this comment.
Consider removing this commented-out code or adding a TODO comment explaining why 'Decrease (<=)' is disabled and when it will be re-enabled to improve code clarity.
Suggested change
| { label: 'Increase (>=)', name: JSON.stringify(['gte']) }, | |
| { label: 'Increase (>=)', name: JSON.stringify(['gte']) }, | |
| // TODO: 'Decrease (<=)' is temporarily disabled due to [reason, e.g., pending design review or testing]. Re-enable when [condition, e.g., feature is approved or tested]. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Skip Review (optional)
style,chore,ci,test,docs)Description (optional)
SSIA
Things to Talk About (optional)