Skip to content

feat(reference-data-model): create reference-data-model & apply to service#5959

Merged
piggggggggy merged 27 commits intofeature-query-integrationfrom
feature-reference-model
Jun 23, 2025
Merged

feat(reference-data-model): create reference-data-model & apply to service#5959
piggggggggy merged 27 commits intofeature-query-integrationfrom
feature-reference-model

Conversation

@piggggggggy
Copy link
Member

Skip Review (optional)

  • Minor changes that don't affect the functionality (e.g. style, chore, ci, test, docs)
  • Previously reviewed in feature branch, further review is not mandatory
  • Self-merge allowed for solo developers or urgent changes

Description (optional)

SSIA
I will share reference-data-model content on wednesday

Things to Talk About (optional)

* chore(query-key): separate query-key helper

Signed-off-by: samuel.park <samuel.park@megazone.com>

* feat(reference-query-key): create reference query-key composable

Signed-off-by: samuel.park <samuel.park@megazone.com>

* chore: small fix

Signed-off-by: samuel.park <samuel.park@megazone.com>

* feat(query-cache-watcher): create query-cache watcher composable

Signed-off-by: samuel.park <samuel.park@megazone.com>

* feat(reference-model-list): create reference-model list composable

Signed-off-by: samuel.park <samuel.park@megazone.com>

* chore: edit composable name

Signed-off-by: samuel.park <samuel.park@megazone.com>

* feat(reference-model): create reference-model type & config

Signed-off-by: samuel.park <samuel.park@megazone.com>

* feat(reference-model-map): create reference-model map data composable

Signed-off-by: samuel.park <samuel.park@megazone.com>

* feat(reference-query): create reference-model query (originally variable model)

Signed-off-by: samuel.park <samuel.park@megazone.com>

* feat(reference-model): create reference-model composable (DSL)

Signed-off-by: samuel.park <samuel.park@megazone.com>

* feat(reference-model): create reference sync composable (for api-clients)

Signed-off-by: samuel.park <samuel.park@megazone.com>

* chore: edit composable name

Signed-off-by: samuel.park <samuel.park@megazone.com>

* chore: create reference-model query type

Signed-off-by: samuel.park <samuel.park@megazone.com>

* feat(reference-model): create reference-model query helper (variable model)

Signed-off-by: samuel.park <samuel.park@megazone.com>

* chore: small fix

Signed-off-by: samuel.park <samuel.park@megazone.com>

* chore: edit typo

Signed-off-by: samuel.park <samuel.park@megazone.com>

---------

Signed-off-by: samuel.park <samuel.park@megazone.com>
* chore: move file architecture

Signed-off-by: samuel.park <samuel.park@megazone.com>

* feat(reference-model): create reference-model core

Signed-off-by: samuel.park <samuel.park@megazone.com>

* chore: small fix

Signed-off-by: samuel.park <samuel.park@megazone.com>

* chore: refactor dir architecture

Signed-off-by: samuel.park <samuel.park@megazone.com>

* chore: apply changed query file path

Signed-off-by: samuel.park <samuel.park@megazone.com>

* fix(reference-model): refactor interface to make it easy to read

Signed-off-by: samuel.park <samuel.park@megazone.com>

* refactor(reference-model): separate reference-model composable & small fix

Signed-off-by: samuel.park <samuel.park@megazone.com>

---------

Signed-off-by: samuel.park <samuel.park@megazone.com>
* feat(reference-model): create reference models & move schema dir

Signed-off-by: samuel.park <samuel.park@megazone.com>

* chore: apply changed schema path

Signed-off-by: samuel.park <samuel.park@megazone.com>

---------

Signed-off-by: samuel.park <samuel.park@megazone.com>
…vider, all) & refactor reference-data-model interface (#5949)

* fix(reference-data-model): refactor reference-data-model interface

Signed-off-by: samuel.park <samuel.park@megazone.com>

* chore: apply changed path

Signed-off-by: samuel.park <samuel.park@megazone.com>

* feat: create reference data model (workspace, ta, secret, region, provider, all)

Signed-off-by: samuel.park <samuel.park@megazone.com>

* chore: apply changed path

Signed-off-by: samuel.park <samuel.park@megazone.com>

* chore: small fix

Signed-off-by: samuel.park <samuel.park@megazone.com>

* chore: edit test code

Signed-off-by: samuel.park <samuel.park@megazone.com>

---------

Signed-off-by: samuel.park <samuel.park@megazone.com>
Signed-off-by: samuel.park <samuel.park@megazone.com>
* fix(reference-data-model): apply reference data model

Signed-off-by: samuel.park <samuel.park@megazone.com>

* fix(provider-button-list): apply reference data model & refactor provider list component

Signed-off-by: samuel.park <samuel.park@megazone.com>

---------

Signed-off-by: samuel.park <samuel.park@megazone.com>
…oup, workspaceGroup, protocol)

Signed-off-by: samuel.park <samuel.park@megazone.com>
Signed-off-by: samuel.park <samuel.park@megazone.com>
Signed-off-by: samuel.park <samuel.park@megazone.com>
Signed-off-by: samuel.park <samuel.park@megazone.com>
Signed-off-by: samuel.park <samuel.park@megazone.com>
Signed-off-by: samuel.park <samuel.park@megazone.com>
Signed-off-by: samuel.park <samuel.park@megazone.com>
Signed-off-by: samuel.park <samuel.park@megazone.com>
Signed-off-by: samuel.park <samuel.park@megazone.com>
Signed-off-by: samuel.park <samuel.park@megazone.com>
Signed-off-by: samuel.park <samuel.park@megazone.com>
Signed-off-by: samuel.park <samuel.park@megazone.com>
Signed-off-by: samuel.park <samuel.park@megazone.com>
Signed-off-by: samuel.park <samuel.park@megazone.com>
Signed-off-by: samuel.park <samuel.park@megazone.com>
Signed-off-by: samuel.park <samuel.park@megazone.com>
Signed-off-by: samuel.park <samuel.park@megazone.com>
Signed-off-by: samuel.park <samuel.park@megazone.com>
@vercel
Copy link

vercel bot commented Jun 23, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

2 Skipped Deployments
Name Status Preview Comments Updated (UTC)
console ⬜️ Ignored (Inspect) Visit Preview Jun 23, 2025 0:27am
web-storybook ⬜️ Ignored (Inspect) Visit Preview Jun 23, 2025 0:27am

@github-actions
Copy link
Contributor

🎉 @yuda110 has been randomly selected as the reviewer! Please review. 🙏

@piggggggggy piggggggggy added the self_approved/review Pull Request has been reviewed and approved by the author without requiring additional reviewers. label Jun 23, 2025
@github-actions github-actions bot requested a review from yuda110 June 23, 2025 08:14
@piggggggggy piggggggggy requested review from Copilot and removed request for yuda110 June 23, 2025 08:14
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR implements the new reference-data-model and replaces the usage of the old reference store in various components across cost explorer, asset inventory, and alert manager modules. Key changes include updating all imports and computed properties to use useAllReferenceDataModel(), adjusting query key usages, and ensuring reference lookups are now sourced uniformly from the new model.

Reviewed Changes

Copilot reviewed 269 out of 427 changed files in this pull request and generated 1 comment.

File Description
apps/web/src/services/cost-explorer/components/CostAnalysisDataTable.vue Replaced old reference-store getters with useAllReferenceDataModel() in computed reference lookups.
apps/web/src/services/asset-inventory/components/CollectorProviderList.vue Updated reference lookups to new model; note the typo in the event name.
apps/web/src/services/alert-manager/v2/** Globally updated reference-store imports to useAllReferenceDataModel() and adjusted query key imports.
Multiple files Systematically substituted useAllReferenceStore() with useAllReferenceDataModel() and adjusted property accesses accordingly.

selectedProvider: 'all',
});

const emit = defineEmits<{(e: 'udpate:selected-provider', value: string): void}>();
Copy link

Copilot AI Jun 23, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The event name 'udpate:selected-provider' appears to be a typo. It should be corrected to 'update:selected-provider' to maintain consistency and avoid potential runtime issues.

Suggested change
const emit = defineEmits<{(e: 'udpate:selected-provider', value: string): void}>();
const emit = defineEmits<{(e: 'update:selected-provider', value: string): void}>();

Copilot uses AI. Check for mistakes.
Signed-off-by: samuel.park <samuel.park@megazone.com>
Signed-off-by: samuel.park <samuel.park@megazone.com>
Signed-off-by: samuel.park <samuel.park@megazone.com>
@piggggggggy piggggggggy merged commit 009f694 into feature-query-integration Jun 23, 2025
10 of 11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

pass/signedoff self_approved/review Pull Request has been reviewed and approved by the author without requiring additional reviewers.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants