Conversation
Signed-off-by: yuda <yuda@megazone.com>
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ |
Contributor
|
🎉 @piggggggggy has been randomly selected as the reviewer! Please review. 🙏 |
Contributor
|
✅ There are no commits in this PR that require review. |
There was a problem hiding this comment.
Pull Request Overview
This PR ensures that the Ticket Board’s task list reacts when categoryId changes by wrapping the context key and query key in computed for proper reactivity.
- Wrap
contextKeyin acomputedto react onprops.categoryIdupdates - Wrap
queryKeyin acomputedto watch the underlying query key ref
Comments suppressed due to low confidence (2)
apps/web/src/services/ops-flow/components/BoardTaskTable.vue:129
- There are no tests verifying that changing
props.categoryIdtriggers a new fetch. Consider adding a unit test to cover this reactive behavior and ensure queries update correctly.
contextKey: computed(() => props.categoryId ?? 'all'),
apps/web/src/services/ops-flow/components/BoardTaskTable.vue:137
- To improve query caching and avoid key collisions, consider using a structured array for
queryKeythat includes the category and any dynamic params, e.g.,computed(() => ['opsflow','task','list', props.categoryId ?? 'all', taskListApiQuery.value]).
queryKey: computed(() => taskListQueryKey.value),
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Skip Review (optional)
style,chore,ci,test,docs)Description (optional)
Things to Talk About (optional)